about summary refs log tree commit diff
path: root/nixpkgs/pkgs/test/nixpkgs-check-by-name/tests/manual-definition/expected
blob: 4d906ec0d086ad970b7934bd31a2b3df372f9256 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
- Because pkgs/by-name/no/noEval exists, the attribute `pkgs.noEval` must be defined like

    noEval = callPackage ./pkgs/by-name/no/noEval/package.nix { /* ... */ };

  However, in this PR, the second argument is empty. See the definition in all-packages.nix:9:

    noEval = self.callPackage ./pkgs/by-name/no/noEval/package.nix { };

  Such a definition is provided automatically and therefore not necessary. Please remove it.

- Because pkgs/by-name/on/onlyMove exists, the attribute `pkgs.onlyMove` must be defined like

    onlyMove = callPackage ./pkgs/by-name/on/onlyMove/package.nix { /* ... */ };

  However, in this PR, the second argument is empty. See the definition in all-packages.nix:7:

    onlyMove = self.callPackage ./pkgs/by-name/on/onlyMove/package.nix { };

  Such a definition is provided automatically and therefore not necessary. Please remove it.

This PR introduces additional instances of discouraged patterns as listed above. Merging is discouraged but would not break the base branch.