about summary refs log tree commit diff
path: root/nixpkgs/pkgs/development/tools/misc/arcanist/dont-require-python3-in-path.patch
blob: 5c127491bb8449cabd564fb2690838e3f3df920b (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
Don't require python3 in PATH

Once packaged, the arcanoid.py script has an absolute path shebang to
python3, so there is no need to also require python3 in PATH.

This prevents leaking in a python3 in PATH in the environment which arc
runs linters etc.

Author: bjorn.forsman@gmail.com
diff -uNr arcanist.orig/src/workflow/ArcanistAnoidWorkflow.php arcanist.new/src/workflow/ArcanistAnoidWorkflow.php
--- arcanist.orig/src/workflow/ArcanistAnoidWorkflow.php	2022-03-31 13:23:30.865095192 +0200
+++ arcanist.new/src/workflow/ArcanistAnoidWorkflow.php	2022-04-01 12:19:15.644159639 +0200
@@ -24,13 +24,6 @@
   }
 
   public function runWorkflow() {
-    if (!Filesystem::binaryExists('python3')) {
-      throw new PhutilArgumentUsageException(
-        pht(
-          'The "arc anoid" workflow requires "python3" to be available '.
-          'in your $PATH.'));
-    }
-
     $support_dir = phutil_get_library_root('arcanist');
     $support_dir = dirname($support_dir);
     $support_dir = $support_dir.'/support/';