about summary refs log tree commit diff
path: root/pkgs
diff options
context:
space:
mode:
authorCorban Raun <corban@raunco.co>2020-05-25 07:46:14 -0600
committerGitHub <noreply@github.com>2020-05-25 08:46:14 -0500
commitc640f7efd1bbbee7a935b06a28f433918f0036aa (patch)
treea6dadc41bea2a27dee9437f23e4dcca8eea51179 /pkgs
parent28667152aa63b42a84ef05775d06bcd4b918c00c (diff)
downloadnixlib-c640f7efd1bbbee7a935b06a28f433918f0036aa.tar
nixlib-c640f7efd1bbbee7a935b06a28f433918f0036aa.tar.gz
nixlib-c640f7efd1bbbee7a935b06a28f433918f0036aa.tar.bz2
nixlib-c640f7efd1bbbee7a935b06a28f433918f0036aa.tar.lz
nixlib-c640f7efd1bbbee7a935b06a28f433918f0036aa.tar.xz
nixlib-c640f7efd1bbbee7a935b06a28f433918f0036aa.tar.zst
nixlib-c640f7efd1bbbee7a935b06a28f433918f0036aa.zip
_1password: do not strip binary on darwin(OSX) (#88091)
Stripping the binary on OSX causes op(1password) to fail immediately.
Setting dontStrip = true; fixes the issue.
Additionally, adding a very simple installCheck section for testing
purposes.

Co-authored-by: Corban Raun <craun@instructure.com>
Diffstat (limited to 'pkgs')
-rw-r--r--pkgs/applications/misc/1password/default.nix8
1 files changed, 8 insertions, 0 deletions
diff --git a/pkgs/applications/misc/1password/default.nix b/pkgs/applications/misc/1password/default.nix
index 010e9ae7a502..22cbb0ec4a09 100644
--- a/pkgs/applications/misc/1password/default.nix
+++ b/pkgs/applications/misc/1password/default.nix
@@ -34,8 +34,16 @@ stdenv.mkDerivation rec {
     install -D op $out/bin/op
   '';
 
+  dontStrip = stdenv.isDarwin;
+
   nativeBuildInputs = stdenv.lib.optionals stdenv.isLinux [ autoPatchelfHook ];
 
+  doInstallCheck = true;
+
+  installCheckPhase = ''
+    $out/bin/op --version
+  '';
+
   meta = with stdenv.lib; {
     description  = "1Password command-line tool";
     homepage     = "https://support.1password.com/command-line/";