tests.nixpkgs-check-by-name: Better empty argument error

4 files changed, 12 insertions, 0 deletions

diff --git a/pkgs/test/nixpkgs-check-by-name/src/nixpkgs_problem.rs b/pkgs/test/nixpkgs-check-by-name/src/nixpkgs_problem.rs
index 03203073fd4a..498284ac6f24 100644
--- a/pkgs/test/nixpkgs-check-by-name/src/nixpkgs_problem.rs
+++ b/pkgs/test/nixpkgs-check-by-name/src/nixpkgs_problem.rs
@@ -213,6 +213,8 @@ impl fmt::Display for NixpkgsProblem {
                       However, in this PR, the second argument is empty. See the definition in {}:{}:
 
                     {}
+
+                      Such a definition is provided automatically and therefore not necessary. Please remove it.
                     ",
                     structure::relative_dir_for_package(package_name).display(),
                     structure::relative_file_for_package(package_name).display(),
diff --git a/pkgs/test/nixpkgs-check-by-name/tests/manual-definition/expected b/pkgs/test/nixpkgs-check-by-name/tests/manual-definition/expected
index 8822e0cc24d4..4d906ec0d086 100644
--- a/pkgs/test/nixpkgs-check-by-name/tests/manual-definition/expected
+++ b/pkgs/test/nixpkgs-check-by-name/tests/manual-definition/expected
@@ -6,6 +6,8 @@
 
     noEval = self.callPackage ./pkgs/by-name/no/noEval/package.nix { };
 
+  Such a definition is provided automatically and therefore not necessary. Please remove it.
+
 - Because pkgs/by-name/on/onlyMove exists, the attribute `pkgs.onlyMove` must be defined like
 
     onlyMove = callPackage ./pkgs/by-name/on/onlyMove/package.nix { /* ... */ };
@@ -14,4 +16,6 @@
 
     onlyMove = self.callPackage ./pkgs/by-name/on/onlyMove/package.nix { };
 
+  Such a definition is provided automatically and therefore not necessary. Please remove it.
+
 This PR introduces additional instances of discouraged patterns as listed above. Merging is discouraged but would not break the base branch.
diff --git a/pkgs/test/nixpkgs-check-by-name/tests/override-empty-arg/expected b/pkgs/test/nixpkgs-check-by-name/tests/override-empty-arg/expected
index 79f78e2437a0..f3306aadbbb7 100644
--- a/pkgs/test/nixpkgs-check-by-name/tests/override-empty-arg/expected
+++ b/pkgs/test/nixpkgs-check-by-name/tests/override-empty-arg/expected
@@ -6,4 +6,6 @@
 
     nonDerivation = self.callPackage ./pkgs/by-name/no/nonDerivation/package.nix { };
 
+  Such a definition is provided automatically and therefore not necessary. Please remove it.
+
 This PR introduces additional instances of discouraged patterns as listed above. Merging is discouraged but would not break the base branch.
diff --git a/pkgs/test/nixpkgs-check-by-name/tests/sorted-order/expected b/pkgs/test/nixpkgs-check-by-name/tests/sorted-order/expected
index 9c7b0d22a610..8a8104b73720 100644
--- a/pkgs/test/nixpkgs-check-by-name/tests/sorted-order/expected
+++ b/pkgs/test/nixpkgs-check-by-name/tests/sorted-order/expected
@@ -6,6 +6,8 @@
 
     a = self.callPackage ./pkgs/by-name/a/a/package.nix { };
 
+  Such a definition is provided automatically and therefore not necessary. Please remove it.
+
 - Attribute `pkgs.b` is a new top-level package using `pkgs.callPackage ... { /* ... */ }`.
   Please define it in pkgs/by-name/b/b/package.nix instead.
   See `pkgs/by-name/README.md` for more details.
@@ -19,6 +21,8 @@
 
     c = self.callPackage ./pkgs/by-name/c/c/package.nix { };
 
+  Such a definition is provided automatically and therefore not necessary. Please remove it.
+
 - Attribute `pkgs.d` is a new top-level package using `pkgs.callPackage ... { /* ... */ }`.
   Please define it in pkgs/by-name/d/d/package.nix instead.
   See `pkgs/by-name/README.md` for more details.