diff options
author | Andrew Childs <lorne@cons.org.nz> | 2019-06-06 22:51:28 +0900 |
---|---|---|
committer | Andrew Childs <lorne@cons.org.nz> | 2019-06-07 00:29:40 +0900 |
commit | b8a6649797a73f75586c589a1b4c8197d9920c43 (patch) | |
tree | b3588ccb56c29cd3b49b95827c865a7e3b6a954a /pkgs/servers/sql/mariadb/default.nix | |
parent | 1dc26c32edffdb73adb0a82b430834d3404aa8f3 (diff) | |
download | nixlib-b8a6649797a73f75586c589a1b4c8197d9920c43.tar nixlib-b8a6649797a73f75586c589a1b4c8197d9920c43.tar.gz nixlib-b8a6649797a73f75586c589a1b4c8197d9920c43.tar.bz2 nixlib-b8a6649797a73f75586c589a1b4c8197d9920c43.tar.lz nixlib-b8a6649797a73f75586c589a1b4c8197d9920c43.tar.xz nixlib-b8a6649797a73f75586c589a1b4c8197d9920c43.tar.zst nixlib-b8a6649797a73f75586c589a1b4c8197d9920c43.zip |
mariadb: fix clang and darwin build
The contents of `clang-isfinite.patch` are no longer necessary after upstream revision 031fa6d4258574379ca3c1cbe912d235e9581982, which includes a similar change. Building in c++11 mode removes support for the GCC `typeof` extension in favor of the standardized `__typeof__`. This causes errors when using the `strmake_buf` macro, which relies on `typeof`.
Diffstat (limited to 'pkgs/servers/sql/mariadb/default.nix')
-rw-r--r-- | pkgs/servers/sql/mariadb/default.nix | 27 |
1 files changed, 19 insertions, 8 deletions
diff --git a/pkgs/servers/sql/mariadb/default.nix b/pkgs/servers/sql/mariadb/default.nix index 988a90e27065..94cdf801ff29 100644 --- a/pkgs/servers/sql/mariadb/default.nix +++ b/pkgs/servers/sql/mariadb/default.nix @@ -9,6 +9,8 @@ with stdenv.lib; let # in mariadb # spans the whole file +libExt = stdenv.hostPlatform.extensions.sharedLibrary; + mariadb = everything // { inherit client; # libmysqlclient.so in .out, necessary headers in .dev and utils in .bin server = everything; # a full single-output build, including everything in `client` again @@ -45,7 +47,11 @@ common = rec { # attributes common to both builds ''; patches = [ ./cmake-includedir.patch ] - ++ stdenv.lib.optional stdenv.cc.isClang ./clang-isfinite.patch; + ++ optionals stdenv.isDarwin [ + # Derived from "Fixed c++11 narrowing error" + # https://github.com/MariaDB/server/commit/a0dfefb0f8a47145e599a5f1b0dc576fa7634b92 + ./fix-c++11-narrowing-error.patch + ]; cmakeFlags = [ "-DBUILD_CONFIG=mysql_release" @@ -112,9 +118,10 @@ client = stdenv.mkDerivation (common // { rm -r "$out"/share/doc rm "$out"/bin/{msql2mysql,mysql_plugin,mytop,wsrep_sst_rsync_wan,mysql_config,mariadb_config} rm "$out"/lib/plugin/{daemon_example.ini,dialog.so,mysql_clear_password.so,sha256_password.so} - rm "$out"/lib/{libmariadb.so,libmysqlclient.so,libmysqlclient_r.so} - mv "$out"/lib/libmariadb.so.3 "$out"/lib/libmysqlclient.so - ln -sv libmysqlclient.so "$out"/lib/libmysqlclient_r.so + libmysqlclient_path=$(readlink -f $out/lib/libmysqlclient${libExt}) + rm "$out"/lib/{libmariadb${libExt},libmysqlclient${libExt},libmysqlclient_r${libExt}} + mv "$libmysqlclient_path" "$out"/lib/libmysqlclient${libExt} + ln -sv libmysqlclient${libExt} "$out"/lib/libmysqlclient_r${libExt} mkdir -p "$dev"/lib && mv "$out"/lib/{libmariadbclient.a,libmysqlclient.a,libmysqlclient_r.a,libmysqlservices.a} "$dev"/lib ''; @@ -161,16 +168,20 @@ everything = stdenv.mkDerivation (common // { rm -r "$out"/data # Don't need testing data rm "$out"/bin/{mysql_find_rows,mysql_waitpid,mysqlaccess,mysqladmin,mysqlbinlog,mysqlcheck} rm "$out"/bin/{mysqldump,mysqlhotcopy,mysqlimport,mysqlshow,mysqlslap,mysqltest} - rm "$out"/lib/mysql/plugin/{auth_gssapi_client.so,client_ed25519.so,daemon_example.ini} - rm "$out"/lib/{libmysqlclient.so,libmysqlclient_r.so} + ${ # We don't build with GSSAPI on Darwin + optionalString (! stdenv.isDarwin) '' + rm "$out"/lib/mysql/plugin/auth_gssapi_client.so + '' + } + rm "$out"/lib/mysql/plugin/{client_ed25519.so,daemon_example.ini} + rm "$out"/lib/{libmysqlclient${libExt},libmysqlclient_r${libExt}} mv "$out"/share/{groonga,groonga-normalizer-mysql} "$out"/share/doc/mysql mkdir -p "$dev"/lib && mv "$out"/lib/{libmariadbclient.a,libmysqlclient.a,libmysqlclient_r.a,libmysqlservices.a} "$dev"/lib '' + optionalString (! stdenv.isDarwin) '' sed -i 's/-mariadb/-mysql/' "$out"/bin/galera_new_cluster ''; - CXXFLAGS = optionalString stdenv.isi686 "-fpermissive" - + optionalString stdenv.isDarwin " -std=c++11"; + CXXFLAGS = optionalString stdenv.isi686 "-fpermissive"; }); connector-c = stdenv.mkDerivation rec { |