diff options
author | Chuck <chuck@intelligence.org> | 2019-09-10 15:52:53 -0700 |
---|---|---|
committer | Chuck <chuck@intelligence.org> | 2019-09-25 09:23:09 -0700 |
commit | a45b3ad89f321d6921f185728f093e6f99724105 (patch) | |
tree | 1be64f309e04ab8f1d7d6c52c3afd7d4a7901b73 /pkgs/development/tools/misc | |
parent | fe5a295a229c791f079f5d83f4d59c409a0e5b90 (diff) | |
download | nixlib-a45b3ad89f321d6921f185728f093e6f99724105.tar nixlib-a45b3ad89f321d6921f185728f093e6f99724105.tar.gz nixlib-a45b3ad89f321d6921f185728f093e6f99724105.tar.bz2 nixlib-a45b3ad89f321d6921f185728f093e6f99724105.tar.lz nixlib-a45b3ad89f321d6921f185728f093e6f99724105.tar.xz nixlib-a45b3ad89f321d6921f185728f093e6f99724105.tar.zst nixlib-a45b3ad89f321d6921f185728f093e6f99724105.zip |
makeWrapper: Remove unused extraFlagsArray feature
There is a bug in this feature: It allows extra arguments to leak in from the environment. For example: $ export extraFlagsArray=date $ man ls Note that you get the man page for date rather than for ls. This happens because 'man' happens to use a wrapper (to add groff to its PATH). An attempt to fix this was made in 5ae18574fce in PR #19328 for issue #2537, but 1. That change didn't actually fix the problem because it addressed makeWrapper's environment during the build process, not the constructed wrapper script's environment after installation, and 2. That change was apparently accidentally lost when merged with 7ff6eec5fd8. Rather than trying to fix the bug again, we remove the extraFlagsArray feature, since it has never been used in the public repo in the ten years it has been available. wrapAclocal continues to use its own, separate flavor of extraFlagsArray in a more limited context. The analogous bug there was fixed in 4d7d10da6b1 in 2011.
Diffstat (limited to 'pkgs/development/tools/misc')
-rw-r--r-- | pkgs/development/tools/misc/ccls/wrapper | 2 | ||||
-rw-r--r-- | pkgs/development/tools/misc/cquery/wrapper | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/pkgs/development/tools/misc/ccls/wrapper b/pkgs/development/tools/misc/ccls/wrapper index f8d7b9eb3fea..155e6d4f6474 100644 --- a/pkgs/development/tools/misc/ccls/wrapper +++ b/pkgs/development/tools/misc/ccls/wrapper @@ -9,4 +9,4 @@ fi initString+="]}}" -exec -a "$0" "@out@/bin/@wrapped@" "${initString}" "${extraFlagsArray[@]}" "$@" +exec -a "$0" "@out@/bin/@wrapped@" "${initString}" "$@" diff --git a/pkgs/development/tools/misc/cquery/wrapper b/pkgs/development/tools/misc/cquery/wrapper index 534f900f94af..8b3e57290429 100644 --- a/pkgs/development/tools/misc/cquery/wrapper +++ b/pkgs/development/tools/misc/cquery/wrapper @@ -9,4 +9,4 @@ fi initString+="]}" -exec -a "$0" "@out@/bin/@wrapped@" "${initString}" "${extraFlagsArray[@]}" "$@" +exec -a "$0" "@out@/bin/@wrapped@" "${initString}" "$@" |