about summary refs log tree commit diff
path: root/pkgs/development/ruby-modules
diff options
context:
space:
mode:
authorFelix Bühler <Stunkymonkey@users.noreply.github.com>2023-07-22 13:02:47 +0200
committerGitHub <noreply@github.com>2023-07-22 13:02:47 +0200
commit0a2745684e8e97340d947d56b0ba778056c10395 (patch)
treec258179185eefafddef480949e84046d3bb50b2e /pkgs/development/ruby-modules
parent4448ec5cd84f00350969934deb4d9ac9055c411c (diff)
parente770737241360cdfd09b421eea83160dce02c212 (diff)
downloadnixlib-0a2745684e8e97340d947d56b0ba778056c10395.tar
nixlib-0a2745684e8e97340d947d56b0ba778056c10395.tar.gz
nixlib-0a2745684e8e97340d947d56b0ba778056c10395.tar.bz2
nixlib-0a2745684e8e97340d947d56b0ba778056c10395.tar.lz
nixlib-0a2745684e8e97340d947d56b0ba778056c10395.tar.xz
nixlib-0a2745684e8e97340d947d56b0ba778056c10395.tar.zst
nixlib-0a2745684e8e97340d947d56b0ba778056c10395.zip
Merge pull request #239624 from Stunkymonkey/use-optionalString-then
treewide: use optionalString instead of 'then ""'
Diffstat (limited to 'pkgs/development/ruby-modules')
-rw-r--r--pkgs/development/ruby-modules/bundled-common/default.nix11
-rw-r--r--pkgs/development/ruby-modules/gem/default.nix2
2 files changed, 7 insertions, 6 deletions
diff --git a/pkgs/development/ruby-modules/bundled-common/default.nix b/pkgs/development/ruby-modules/bundled-common/default.nix
index b18248c7d61b..86c885b52dcb 100644
--- a/pkgs/development/ruby-modules/bundled-common/default.nix
+++ b/pkgs/development/ruby-modules/bundled-common/default.nix
@@ -70,11 +70,12 @@ let
       assert gemFiles.gemdir != null; "cp -a ${gemFiles.gemdir}/* $out/") #*/
   );
 
-  maybeCopyAll = pkgname: if pkgname == null then "" else
-  let
-    mainGem = gems.${pkgname} or (throw "bundlerEnv: gem ${pkgname} not found");
-  in
-    copyIfBundledByPath mainGem;
+  maybeCopyAll = pkgname: lib.optionalString (pkgname != null) (
+    let
+      mainGem = gems.${pkgname} or (throw "bundlerEnv: gem ${pkgname} not found");
+    in
+      copyIfBundledByPath mainGem
+  );
 
   # We have to normalize the Gemfile.lock, otherwise bundler tries to be
   # helpful by doing so at run time, causing executables to immediately bail
diff --git a/pkgs/development/ruby-modules/gem/default.nix b/pkgs/development/ruby-modules/gem/default.nix
index b33758486eed..7ae9168975ab 100644
--- a/pkgs/development/ruby-modules/gem/default.nix
+++ b/pkgs/development/ruby-modules/gem/default.nix
@@ -233,7 +233,7 @@ stdenv.mkDerivation ((builtins.removeAttrs attrs ["source"]) // {
     pushd $out/${ruby.gemPath}
     find doc/ -iname created.rid -delete -print
     find gems/*/ext/ extensions/ \( -iname Makefile -o -iname mkmf.log -o -iname gem_make.out \) -delete -print
-    ${if keepGemCache then "" else "rm -fvr cache"}
+    ${lib.optionalString (!keepGemCache) "rm -fvr cache"}
     popd
 
     # write out metadata and binstubs