diff options
author | Yegor Timoshenko <yegortimoshenko@gmail.com> | 2017-12-21 02:58:58 +0000 |
---|---|---|
committer | Yegor Timoshenko <yegortimoshenko@gmail.com> | 2017-12-22 18:56:13 +0300 |
commit | 73a0d95b96d9aecc9c0ed6fa4407e1537170db53 (patch) | |
tree | 89924317af6f6c1c1dfb4603cad567ad40d82229 /pkgs/development/python-modules/hupper | |
parent | 710662be948d9013390241469c877dc97ca19e1a (diff) | |
download | nixlib-73a0d95b96d9aecc9c0ed6fa4407e1537170db53.tar nixlib-73a0d95b96d9aecc9c0ed6fa4407e1537170db53.tar.gz nixlib-73a0d95b96d9aecc9c0ed6fa4407e1537170db53.tar.bz2 nixlib-73a0d95b96d9aecc9c0ed6fa4407e1537170db53.tar.lz nixlib-73a0d95b96d9aecc9c0ed6fa4407e1537170db53.tar.xz nixlib-73a0d95b96d9aecc9c0ed6fa4407e1537170db53.tar.zst nixlib-73a0d95b96d9aecc9c0ed6fa4407e1537170db53.zip |
chrootenv: code review
* Wrap LEN macro in parantheses * Drop env_filter in favor of stateful environ_blacklist_filter, use execvp instead of execvpe, don't explicitly use environ * Add argument error logging wherever it makes sense * Drop strjoin in favor of asprintf * char* -> const char* where appropriate * Handle stat errors * Print user messages with fputs, not errorf * Abstract away is_str_in (previously bind_blacklisted) * Cleanup temporary directory on error * Some minor syntactic and naming changes Thanks to Jörg Thalheim and Tuomas Tynkkynen for the code review!
Diffstat (limited to 'pkgs/development/python-modules/hupper')
0 files changed, 0 insertions, 0 deletions