about summary refs log tree commit diff
path: root/pkgs/development/compilers
diff options
context:
space:
mode:
authorDima <dgoldin+github@protonmail.ch>2019-10-04 08:12:04 +0200
committerVladimír Čunát <v@cunat.cz>2019-10-16 10:49:22 +0200
commitcffba01e12661ab91252be03a07567db7d1f0f29 (patch)
tree9c9944150609459a2543aeb1a9611a7b035f96b3 /pkgs/development/compilers
parent3f93a09405f04c639031f7766928ac3bf8d5f63f (diff)
downloadnixlib-cffba01e12661ab91252be03a07567db7d1f0f29.tar
nixlib-cffba01e12661ab91252be03a07567db7d1f0f29.tar.gz
nixlib-cffba01e12661ab91252be03a07567db7d1f0f29.tar.bz2
nixlib-cffba01e12661ab91252be03a07567db7d1f0f29.tar.lz
nixlib-cffba01e12661ab91252be03a07567db7d1f0f29.tar.xz
nixlib-cffba01e12661ab91252be03a07567db7d1f0f29.tar.zst
nixlib-cffba01e12661ab91252be03a07567db7d1f0f29.zip
go_1_12: disable flakey TestGcSys test (PR #70368)
In our tests we have experienced failures of this test,
but it was otherwise not reproducible so far. A backported
upstream fix did not alleviate the issue either, so disabling
seems workable for now.
Diffstat (limited to 'pkgs/development/compilers')
-rw-r--r--pkgs/development/compilers/go/1.12.nix6
1 files changed, 6 insertions, 0 deletions
diff --git a/pkgs/development/compilers/go/1.12.nix b/pkgs/development/compilers/go/1.12.nix
index 7a6c0b041fc4..a1476c36abba 100644
--- a/pkgs/development/compilers/go/1.12.nix
+++ b/pkgs/development/compilers/go/1.12.nix
@@ -96,6 +96,12 @@ stdenv.mkDerivation rec {
     # Disable cgo lookup tests not works, they depend on resolver
     rm src/net/cgo_unix_test.go
 
+    # Disable TestGcSys because it's flakey in our tests, but the failure is not
+    # reproducible by multiple people in other environments.
+    # See https://github.com/NixOS/nixpkgs/issues/68361#issuecomment-537849272 and following
+    # NOTE: Try re-enabling for releases newer than 1.12.9
+    sed -i '/TestGcSys/areturn' src/runtime/gc_test.go
+
   '' + optionalString stdenv.isLinux ''
     sed -i 's,/usr/share/zoneinfo/,${tzdata}/share/zoneinfo/,' src/time/zoneinfo_unix.go
   '' + optionalString stdenv.isAarch32 ''