diff options
author | Winter <winter@winter.cafe> | 2022-12-15 18:38:33 -0500 |
---|---|---|
committer | Winter <winter@winter.cafe> | 2022-12-23 13:55:46 -0500 |
commit | b1834a461edf7abf4a6fb89db0ed65904a48a01c (patch) | |
tree | 6b401ad5dd9973b0783ebe86e2b0b0a49cd3cbe8 /pkgs/development/compilers/rust | |
parent | 1ffbdda604b5c0daf6cbd521aa09b21cdc72f55c (diff) | |
download | nixlib-b1834a461edf7abf4a6fb89db0ed65904a48a01c.tar nixlib-b1834a461edf7abf4a6fb89db0ed65904a48a01c.tar.gz nixlib-b1834a461edf7abf4a6fb89db0ed65904a48a01c.tar.bz2 nixlib-b1834a461edf7abf4a6fb89db0ed65904a48a01c.tar.lz nixlib-b1834a461edf7abf4a6fb89db0ed65904a48a01c.tar.xz nixlib-b1834a461edf7abf4a6fb89db0ed65904a48a01c.tar.zst nixlib-b1834a461edf7abf4a6fb89db0ed65904a48a01c.zip |
Revert "rustc: propagate libiconv on darwin"
This reverts commit b6fc00b8f4bc25a72c43320b70082bbee06321db. Rust 1.66.0 contains a fix for libiconv being linked unconditionally on macOS, but this only applies to packages that don't depend on older versions of `libc`. For now, let's go back to including libiconv in `buildInputs` by default for packages that use `buildRustPackage`. As packages bump their `libc` versions, we can eventually stop including it by default, and manually add it where needed.
Diffstat (limited to 'pkgs/development/compilers/rust')
-rw-r--r-- | pkgs/development/compilers/rust/cargo.nix | 4 | ||||
-rw-r--r-- | pkgs/development/compilers/rust/rustc.nix | 4 |
2 files changed, 3 insertions, 5 deletions
diff --git a/pkgs/development/compilers/rust/cargo.nix b/pkgs/development/compilers/rust/cargo.nix index 5571918fdc62..291a64f2210c 100644 --- a/pkgs/development/compilers/rust/cargo.nix +++ b/pkgs/development/compilers/rust/cargo.nix @@ -1,7 +1,7 @@ { lib, stdenv, pkgsHostHost , file, curl, pkg-config, python3, openssl, cmake, zlib , installShellFiles, makeWrapper, cacert, rustPlatform, rustc -, libiconv, CoreFoundation, Security +, CoreFoundation, Security , auditable ? false # TODO: change to true when this is the default }: @@ -28,7 +28,7 @@ rustPlatform.buildRustPackage { (lib.getDev pkgsHostHost.curl) ]; buildInputs = [ cacert file curl python3 openssl zlib ] - ++ lib.optionals stdenv.isDarwin [ libiconv CoreFoundation Security ]; + ++ lib.optionals stdenv.isDarwin [ CoreFoundation Security ]; # cargo uses git-rs which is made for a version of libgit2 from recent master that # is not compatible with the current version in nixpkgs. diff --git a/pkgs/development/compilers/rust/rustc.nix b/pkgs/development/compilers/rust/rustc.nix index 8288cd5c61e3..06d9de15ab8d 100644 --- a/pkgs/development/compilers/rust/rustc.nix +++ b/pkgs/development/compilers/rust/rustc.nix @@ -163,11 +163,9 @@ in stdenv.mkDerivation rec { ]; buildInputs = [ openssl ] - ++ optionals stdenv.isDarwin [ Security ] + ++ optionals stdenv.isDarwin [ libiconv Security ] ++ optional (!withBundledLLVM) llvmShared; - depsTargetTargetPropagated = optionals stdenv.isDarwin [ libiconv ]; - outputs = [ "out" "man" "doc" ]; setOutputFlags = false; |