diff options
| author | Bob van der Linden <bobvanderlinden@gmail.com> | 2018-09-15 18:46:18 +0200 |
|---|---|---|
| committer | Bob van der Linden <bobvanderlinden@gmail.com> | 2018-09-15 18:46:18 +0200 |
| commit | 0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7 (patch) | |
| tree | 7716e2cc0ca058a56806c47f2b21239500fd1103 /pkgs/development/compilers/go | |
| parent | b78348d1a4b967288b06caf35eb4e26f0f65fa1e (diff) | |
| download | nixlib-0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7.tar nixlib-0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7.tar.gz nixlib-0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7.tar.bz2 nixlib-0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7.tar.lz nixlib-0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7.tar.xz nixlib-0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7.tar.zst nixlib-0bf6b440d90acc6b581c6dd18ce3eb6b335eccd7.zip | |
go: skip flaky os/exec TestExtraFiles
This seems to only happen on i686 on go 1.11. It also happens on Debian. For more information: https://github.com/golang/go/issues/25628
Diffstat (limited to 'pkgs/development/compilers/go')
| -rw-r--r-- | pkgs/development/compilers/go/1.11.nix | 1 | ||||
| -rw-r--r-- | pkgs/development/compilers/go/skip-test-extra-files-on-386.patch | 15 |
2 files changed, 16 insertions, 0 deletions
diff --git a/pkgs/development/compilers/go/1.11.nix b/pkgs/development/compilers/go/1.11.nix index 237f74e319f7..4a84c622a73e 100644 --- a/pkgs/development/compilers/go/1.11.nix +++ b/pkgs/development/compilers/go/1.11.nix @@ -125,6 +125,7 @@ stdenv.mkDerivation rec { ./remove-fhs-test-references.patch ./skip-external-network-tests.patch ./skip-nohup-tests.patch + ./skip-test-extra-files-on-386.patch ]; postPatch = optionalString stdenv.isDarwin '' diff --git a/pkgs/development/compilers/go/skip-test-extra-files-on-386.patch b/pkgs/development/compilers/go/skip-test-extra-files-on-386.patch new file mode 100644 index 000000000000..afe5aea3d916 --- /dev/null +++ b/pkgs/development/compilers/go/skip-test-extra-files-on-386.patch @@ -0,0 +1,15 @@ +diff --git a/src/os/exec/exec_test.go b/src/os/exec/exec_test.go +index 558345ff63..22129bf022 100644 +--- a/src/os/exec/exec_test.go ++++ b/src/os/exec/exec_test.go +@@ -593,6 +593,10 @@ func TestExtraFiles(t *testing.T) { + t.Skipf("skipping test on %q", runtime.GOOS) + } + ++ if runtime.GOOS == "linux" && runtime.GOARCH == "386" { ++ t.Skipf("skipping test on %q %q", runtime.GOARCH, runtime.GOOS) ++ } ++ + // Ensure that file descriptors have not already been leaked into + // our environment. + if !testedAlreadyLeaked { |