about summary refs log tree commit diff
path: root/pkgs/applications/version-management/git-and-tools
diff options
context:
space:
mode:
authorMichael Weiss <dev.primeos@gmail.com>2020-04-21 14:02:17 +0200
committerMichael Weiss <dev.primeos@gmail.com>2020-04-21 14:30:11 +0200
commit666042141ed2039fdb136ccc89ca1aff6a495ec4 (patch)
tree25fdcf88bba3f00396536922f85dbbddebfe0e5f /pkgs/applications/version-management/git-and-tools
parent77cb7ad618a971bf9e9376cd6e6911593dd70ebb (diff)
downloadnixlib-666042141ed2039fdb136ccc89ca1aff6a495ec4.tar
nixlib-666042141ed2039fdb136ccc89ca1aff6a495ec4.tar.gz
nixlib-666042141ed2039fdb136ccc89ca1aff6a495ec4.tar.bz2
nixlib-666042141ed2039fdb136ccc89ca1aff6a495ec4.tar.lz
nixlib-666042141ed2039fdb136ccc89ca1aff6a495ec4.tar.xz
nixlib-666042141ed2039fdb136ccc89ca1aff6a495ec4.tar.zst
nixlib-666042141ed2039fdb136ccc89ca1aff6a495ec4.zip
git: Fix the update.sh script and use HTTPS
The syntax is ${parameter:-word} (i.e. previously this used
"latestTag" instead of the actual value).
(Fixes a regression from #85278.)

Also: Even though getting the latest tag isn't really security critical
(as long as Git itself is secure against untrusted input), I'd prefer to
switch from the Git to the HTTPS protocol (for authentication of the
server and encryption + uses a standard port).
Diffstat (limited to 'pkgs/applications/version-management/git-and-tools')
-rwxr-xr-xpkgs/applications/version-management/git-and-tools/git/update.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/pkgs/applications/version-management/git-and-tools/git/update.sh b/pkgs/applications/version-management/git-and-tools/git/update.sh
index d0bc413fb893..54574722b02b 100755
--- a/pkgs/applications/version-management/git-and-tools/git/update.sh
+++ b/pkgs/applications/version-management/git-and-tools/git/update.sh
@@ -4,8 +4,8 @@
 set -eu -o pipefail
 
 oldVersion="$(nix-instantiate --eval -E "with import ./. {}; lib.getVersion git" | tr -d '"')"
-latestTag="$(git ls-remote --tags --sort="v:refname" git://github.com/git/git.git | grep -v '\{\}' | grep -v '\-rc' | tail -1 | sed 's|^.*/v\(.*\)|\1|')"
-targetVersion="${1:-latestTag}"
+latestTag="$(git ls-remote --tags --sort="v:refname" https://github.com/git/git.git | grep -v '\{\}' | grep -v '\-rc' | tail -1 | sed 's|^.*/v\(.*\)|\1|')"
+targetVersion="${1:-$latestTag}"
 
 if [ ! "${oldVersion}" = "${targetVersion}" ]; then
   update-source-version git "${targetVersion}"