about summary refs log tree commit diff
path: root/pkgs/applications/networking/browsers/ungoogled-chromium/patches/dont-use-ANGLE-by-default.patch
diff options
context:
space:
mode:
authorFrederik Rietdijk <fridh@fridh.nl>2020-04-25 07:53:37 +0200
committerFrederik Rietdijk <fridh@fridh.nl>2020-04-25 07:53:37 +0200
commitbb10352242dceb863069797bb92131944b0ac62f (patch)
treed3f5ceea6723e3d6c901652146e41ffe45100c9b /pkgs/applications/networking/browsers/ungoogled-chromium/patches/dont-use-ANGLE-by-default.patch
parent7fb1ff90031c59cbc9ef79224516a74bc138c7a6 (diff)
parent5c70040db2dd2123f7728f1bdcd40d5018de0ef9 (diff)
downloadnixlib-bb10352242dceb863069797bb92131944b0ac62f.tar
nixlib-bb10352242dceb863069797bb92131944b0ac62f.tar.gz
nixlib-bb10352242dceb863069797bb92131944b0ac62f.tar.bz2
nixlib-bb10352242dceb863069797bb92131944b0ac62f.tar.lz
nixlib-bb10352242dceb863069797bb92131944b0ac62f.tar.xz
nixlib-bb10352242dceb863069797bb92131944b0ac62f.tar.zst
nixlib-bb10352242dceb863069797bb92131944b0ac62f.zip
Merge staging-next into staging
Diffstat (limited to 'pkgs/applications/networking/browsers/ungoogled-chromium/patches/dont-use-ANGLE-by-default.patch')
-rw-r--r--pkgs/applications/networking/browsers/ungoogled-chromium/patches/dont-use-ANGLE-by-default.patch26
1 files changed, 26 insertions, 0 deletions
diff --git a/pkgs/applications/networking/browsers/ungoogled-chromium/patches/dont-use-ANGLE-by-default.patch b/pkgs/applications/networking/browsers/ungoogled-chromium/patches/dont-use-ANGLE-by-default.patch
new file mode 100644
index 000000000000..9f14a304eb34
--- /dev/null
+++ b/pkgs/applications/networking/browsers/ungoogled-chromium/patches/dont-use-ANGLE-by-default.patch
@@ -0,0 +1,26 @@
+A field trial currently enables the passthrough command decoder, which causes
+gl_factory.cc to try kGLImplementationEGLANGLE first, which causes Chromium to fail
+to load libGLESv2.so on NixOS.  It somehow does not try kGLImplementationDesktopGL,
+and so there is no GL support at all.
+
+Revert to using the validating command decoder, which prevents gl_factory.cc
+from touching allowed_impls, allowing it to successfully use kGLImplementationDesktopGL.
+
+diff --git a/ui/gl/gl_utils.cc b/ui/gl/gl_utils.cc
+index 697cbed5fe2d..8419bdb21a2f 100644
+--- a/ui/gl/gl_utils.cc
++++ b/ui/gl/gl_utils.cc
+@@ -71,9 +71,10 @@ bool UsePassthroughCommandDecoder(const base::CommandLine* command_line) {
+   } else if (switch_value == kCmdDecoderValidatingName) {
+     return false;
+   } else {
+-    // Unrecognized or missing switch, use the default.
+-    return base::FeatureList::IsEnabled(
+-        features::kDefaultPassthroughCommandDecoder);
++    // Ignore the field trial that enables it; disable it until
++    // gl_factory.cc kGLImplementationEGLANGLE issues are sorted
++    // out on NixOS.
++    return false;
+   }
+ }
+ }