diff options
author | Timo Kaufmann <timokau@zoho.com> | 2020-03-31 19:37:28 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-31 19:37:28 +0000 |
commit | c9bf23e6583164033d0cdce83825f3bb288de9b7 (patch) | |
tree | 3316633c04d64d6e9788034eb7f7744fab8f87ad /pkgs/applications/audio | |
parent | abe5f7070a50f99a6338f11397cf29d9611d7490 (diff) | |
parent | babd73454a138e829bdef1bd252a2ec4359923b3 (diff) | |
download | nixlib-c9bf23e6583164033d0cdce83825f3bb288de9b7.tar nixlib-c9bf23e6583164033d0cdce83825f3bb288de9b7.tar.gz nixlib-c9bf23e6583164033d0cdce83825f3bb288de9b7.tar.bz2 nixlib-c9bf23e6583164033d0cdce83825f3bb288de9b7.tar.lz nixlib-c9bf23e6583164033d0cdce83825f3bb288de9b7.tar.xz nixlib-c9bf23e6583164033d0cdce83825f3bb288de9b7.tar.zst nixlib-c9bf23e6583164033d0cdce83825f3bb288de9b7.zip |
Merge pull request #83482 from doronbehar/improve-picard
picard: add optional qtmultimedia dependency
Diffstat (limited to 'pkgs/applications/audio')
-rw-r--r-- | pkgs/applications/audio/picard/default.nix | 33 |
1 files changed, 27 insertions, 6 deletions
diff --git a/pkgs/applications/audio/picard/default.nix b/pkgs/applications/audio/picard/default.nix index b241f750d036..5830e1eefb88 100644 --- a/pkgs/applications/audio/picard/default.nix +++ b/pkgs/applications/audio/picard/default.nix @@ -1,7 +1,15 @@ -{ stdenv, python3Packages, fetchFromGitHub, gettext, chromaprint, qt5 }: +{ stdenv, python3Packages, fetchFromGitHub, gettext, chromaprint, qt5 +, enablePlayback ? true +, gst_all_1 +}: let pythonPackages = python3Packages; + pyqt5 = if enablePlayback then + pythonPackages.pyqt5_with_qtmultimedia + else + pythonPackages.pyqt5 + ; in pythonPackages.buildPythonApplication rec { pname = "picard"; version = "2.3.1"; @@ -13,7 +21,16 @@ in pythonPackages.buildPythonApplication rec { sha256 = "0xalg4dvaqb396h4s6gzxnplgv1lcvsczmmrlhyrj0kfj10amhsj"; }; - nativeBuildInputs = [ gettext qt5.wrapQtAppsHook qt5.qtbase ]; + nativeBuildInputs = [ gettext qt5.wrapQtAppsHook qt5.qtbase ] + ++ stdenv.lib.optionals (pyqt5.multimediaEnabled) [ + qt5.qtmultimedia.bin + gst_all_1.gstreamer + gst_all_1.gst-vaapi + gst_all_1.gst-libav + gst_all_1.gst-plugins-base + gst_all_1.gst-plugins-good + ] + ; propagatedBuildInputs = with pythonPackages; [ pyqt5 @@ -27,10 +44,14 @@ in pythonPackages.buildPythonApplication rec { substituteInPlace setup.cfg --replace "‘" "'" ''; - installPhase = '' - python setup.py install --prefix="$out" - wrapQtApp $out/bin/picard - ''; + # In order to spare double wrapping, we use: + preFixup = '' + makeWrapperArgs+=("''${qtWrapperArgs[@]}") + '' + + stdenv.lib.optionalString (pyqt5.multimediaEnabled) '' + makeWrapperArgs+=(--prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "$GST_PLUGIN_SYSTEM_PATH_1_0") + '' + ; meta = with stdenv.lib; { homepage = "https://picard.musicbrainz.org/"; |