about summary refs log tree commit diff
path: root/pkgs/applications/audio
diff options
context:
space:
mode:
authorGreg Price <gnprice@gmail.com>2020-04-08 23:41:41 -0700
committerFrederik Rietdijk <freddyrietdijk@fridh.nl>2020-04-21 07:51:55 +0200
commit45a04ed6d49a35f88fd34701ca06c8676d2cb148 (patch)
treec0bfb524a831318914cf1dc1007e5911464dfe69 /pkgs/applications/audio
parent5dc6f02d77997bf8eaa3591cc59dbaae4c304577 (diff)
downloadnixlib-45a04ed6d49a35f88fd34701ca06c8676d2cb148.tar
nixlib-45a04ed6d49a35f88fd34701ca06c8676d2cb148.tar.gz
nixlib-45a04ed6d49a35f88fd34701ca06c8676d2cb148.tar.bz2
nixlib-45a04ed6d49a35f88fd34701ca06c8676d2cb148.tar.lz
nixlib-45a04ed6d49a35f88fd34701ca06c8676d2cb148.tar.xz
nixlib-45a04ed6d49a35f88fd34701ca06c8676d2cb148.tar.zst
nixlib-45a04ed6d49a35f88fd34701ca06c8676d2cb148.zip
gbsplay: fix configure flags
This caused none of these flags to have any effect.  That's because
the configure command looked like this:

    ./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \
        --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n

with one giant flag '--without-test --without-contrib...', containing
internal spaces.

This can be seen in `nix log nixpkgs.gbsplay`, in this line:

    configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n

and then in the fact that features like "devdsp" and "midi" are listed
as enabled in later output, and source files like plugout_midi.c are
included in the build.

I don't have a real opinion on whether it's better to have these flags
or not, but it's clear the author's intention was to pass them.  So,
fix the attr name so they get passed.
Diffstat (limited to 'pkgs/applications/audio')
-rw-r--r--pkgs/applications/audio/gbsplay/default.nix6
1 files changed, 3 insertions, 3 deletions
diff --git a/pkgs/applications/audio/gbsplay/default.nix b/pkgs/applications/audio/gbsplay/default.nix
index 9ff9b8dc1145..f89b8ed399b4 100644
--- a/pkgs/applications/audio/gbsplay/default.nix
+++ b/pkgs/applications/audio/gbsplay/default.nix
@@ -11,13 +11,13 @@ stdenv.mkDerivation {
   };
 
   buildInputs = [ libpulseaudio ];
-  
-  configureFlagsArray =
+
+  configureFlags =
    [ "--without-test" "--without-contrib" "--disable-devdsp"
      "--enable-pulse" "--disable-alsa" "--disable-midi"
      "--disable-nas" "--disable-dsound" "--disable-i18n" ];
 
-  makeFlagsArray = [ "tests=" ];
+  makeFlags = [ "tests=" ];
 
   meta = with stdenv.lib; {
     description = "gameboy sound player";