about summary refs log tree commit diff
path: root/nixpkgs/pkgs/tools/misc
diff options
context:
space:
mode:
authorMatthew Bauer <mjbauer95@gmail.com>2020-06-26 16:44:45 -0400
committerAlyssa Ross <hi@alyssa.is>2020-11-27 13:27:40 +0000
commit559564159b47c7d308b178b237c90d51dc4b85e7 (patch)
tree4668bee7dec92641bff51458de1ce4742643ed29 /nixpkgs/pkgs/tools/misc
parentc3a716401a7a330b83628dd524d6e7bc68c88a44 (diff)
downloadnixlib-559564159b47c7d308b178b237c90d51dc4b85e7.tar
nixlib-559564159b47c7d308b178b237c90d51dc4b85e7.tar.gz
nixlib-559564159b47c7d308b178b237c90d51dc4b85e7.tar.bz2
nixlib-559564159b47c7d308b178b237c90d51dc4b85e7.tar.lz
nixlib-559564159b47c7d308b178b237c90d51dc4b85e7.tar.xz
nixlib-559564159b47c7d308b178b237c90d51dc4b85e7.tar.zst
nixlib-559564159b47c7d308b178b237c90d51dc4b85e7.zip
treewide: add warning comment to “boot” packages
This adds a warning to the top of each “boot” package that reads:

  Note: this package is used for bootstrapping fetchurl, and thus cannot
  use fetchpatch! All mutable patches (generated by GitHub or cgit) that
  are needed here should be included directly in Nixpkgs as files.

This makes it clear to maintainer that they may need to treat this
package a little differently than others. Importantly, we can’t use
fetchpatch here due to using <nix/fetchurl.nix>. To avoid having stale
hashes, we need to include patches that are subject to changing
overtime (for instance, gitweb’s patches contain a version number at
the bottom).

(cherry picked from commit d0677e6d45c4acf9fdd3f09e77f7201794a45a82)
Diffstat (limited to 'nixpkgs/pkgs/tools/misc')
-rw-r--r--nixpkgs/pkgs/tools/misc/coreutils/default.nix5
-rw-r--r--nixpkgs/pkgs/tools/misc/findutils/default.nix5
2 files changed, 10 insertions, 0 deletions
diff --git a/nixpkgs/pkgs/tools/misc/coreutils/default.nix b/nixpkgs/pkgs/tools/misc/coreutils/default.nix
index 49edc002bec7..50d3a2437d70 100644
--- a/nixpkgs/pkgs/tools/misc/coreutils/default.nix
+++ b/nixpkgs/pkgs/tools/misc/coreutils/default.nix
@@ -10,6 +10,11 @@
 , singleBinary ? "symlinks" # you can also pass "shebangs" or false
 }:
 
+# Note: this package is used for bootstrapping fetchurl, and thus
+# cannot use fetchpatch! All mutable patches (generated by GitHub or
+# cgit) that are needed here should be included directly in Nixpkgs as
+# files.
+
 assert aclSupport -> acl != null;
 assert selinuxSupport -> libselinux != null && libsepol != null;
 
diff --git a/nixpkgs/pkgs/tools/misc/findutils/default.nix b/nixpkgs/pkgs/tools/misc/findutils/default.nix
index 1b69b80be70f..651b04c3bb54 100644
--- a/nixpkgs/pkgs/tools/misc/findutils/default.nix
+++ b/nixpkgs/pkgs/tools/misc/findutils/default.nix
@@ -2,6 +2,11 @@
 , coreutils
 }:
 
+# Note: this package is used for bootstrapping fetchurl, and thus
+# cannot use fetchpatch! All mutable patches (generated by GitHub or
+# cgit) that are needed here should be included directly in Nixpkgs as
+# files.
+
 stdenv.mkDerivation rec {
   pname = "findutils";
   version = "4.7.0";