diff options
author | Alyssa Ross <hi@alyssa.is> | 2022-01-03 23:55:00 +0000 |
---|---|---|
committer | Alyssa Ross <hi@alyssa.is> | 2022-02-19 11:03:39 +0000 |
commit | f4cf97a04cd5d0b86aa46baec9fb228a8f671c03 (patch) | |
tree | 28192415ff39a661d0001563bf81cc93fa25d16d /nixpkgs/pkgs/development/libraries/polkit | |
parent | f8422837c9bde058e8f2de37702e7e94b2226040 (diff) | |
parent | 18c84ea816348e2a098390101b92d1e39a9dbd45 (diff) | |
download | nixlib-f4cf97a04cd5d0b86aa46baec9fb228a8f671c03.tar nixlib-f4cf97a04cd5d0b86aa46baec9fb228a8f671c03.tar.gz nixlib-f4cf97a04cd5d0b86aa46baec9fb228a8f671c03.tar.bz2 nixlib-f4cf97a04cd5d0b86aa46baec9fb228a8f671c03.tar.lz nixlib-f4cf97a04cd5d0b86aa46baec9fb228a8f671c03.tar.xz nixlib-f4cf97a04cd5d0b86aa46baec9fb228a8f671c03.tar.zst nixlib-f4cf97a04cd5d0b86aa46baec9fb228a8f671c03.zip |
Merge commit '18c84ea816348e2a098390101b92d1e39a9dbd45'
Conflicts: nixpkgs/nixos/modules/misc/documentation.nix nixpkgs/pkgs/applications/networking/browsers/firefox/packages.nix nixpkgs/pkgs/applications/window-managers/sway/default.nix nixpkgs/pkgs/build-support/rust/build-rust-package/default.nix nixpkgs/pkgs/development/go-modules/generic/default.nix nixpkgs/pkgs/development/interpreters/ruby/default.nix nixpkgs/pkgs/development/interpreters/ruby/patchsets.nix nixpkgs/pkgs/development/libraries/boehm-gc/7.6.6.nix nixpkgs/pkgs/development/python-modules/django-mailman3/default.nix nixpkgs/pkgs/servers/mail/mailman/web.nix nixpkgs/pkgs/top-level/aliases.nix nixpkgs/pkgs/top-level/all-packages.nix nixpkgs/pkgs/top-level/impure.nix
Diffstat (limited to 'nixpkgs/pkgs/development/libraries/polkit')
-rw-r--r-- | nixpkgs/pkgs/development/libraries/polkit/default.nix | 187 |
1 files changed, 130 insertions, 57 deletions
diff --git a/nixpkgs/pkgs/development/libraries/polkit/default.nix b/nixpkgs/pkgs/development/libraries/polkit/default.nix index a8b012a20998..bd731e7b0517 100644 --- a/nixpkgs/pkgs/development/libraries/polkit/default.nix +++ b/nixpkgs/pkgs/development/libraries/polkit/default.nix @@ -1,7 +1,28 @@ -{ lib, stdenv, fetchurl, pkg-config, glib, expat, pam, perl, fetchpatch -, intltool, spidermonkey_78, gobject-introspection, libxslt, docbook_xsl, dbus -, docbook_xml_dtd_412, gtk-doc, coreutils -, useSystemd ? (stdenv.isLinux && !stdenv.hostPlatform.isMusl), systemd, elogind +{ lib +, stdenv +, fetchFromGitLab +, pkg-config +, glib +, expat +, pam +, meson +, ninja +, perl +, rsync +, python3 +, fetchpatch +, gettext +, spidermonkey_78 +, gobject-introspection +, libxslt +, docbook-xsl-nons +, dbus +, docbook_xml_dtd_412 +, gtk-doc +, coreutils +, useSystemd ? stdenv.isLinux +, systemd +, elogind # needed until gobject-introspection does cross-compile (https://github.com/NixOS/nixpkgs/pull/88222) , withIntrospection ? (stdenv.buildPlatform == stdenv.hostPlatform) # A few tests currently fail on musl (polkitunixusertest, polkitunixgrouptest, polkitidentitytest segfault). @@ -12,54 +33,111 @@ }: let - system = "/run/current-system/sw"; setuid = "/run/wrappers/bin"; - in - stdenv.mkDerivation rec { pname = "polkit"; - version = "0.119"; + version = "0.120"; + + outputs = [ "bin" "dev" "out" ]; # small man pages in $bin - src = fetchurl { - url = "https://www.freedesktop.org/software/${pname}/releases/${pname}-${version}.tar.gz"; - sha256 = "0p0zzmr0kh3mpmqya4q27y4h9b920zp5ya0i8909ahp9hvdrymy8"; + # Tarballs do not contain subprojects. + src = fetchFromGitLab { + domain = "gitlab.freedesktop.org"; + owner = "polkit"; + repo = "polkit"; + rev = version; + sha256 = "oEaRf1g13zKMD+cP1iwIA6jaCDwvNfGy2i8xY8vuVSo="; }; - patches = lib.optionals stdenv.hostPlatform.isMusl [ + patches = [ + # Allow changing base for paths in pkg-config file as before. + # https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/100 + (fetchpatch { + url = "https://gitlab.freedesktop.org/polkit/polkit/-/commit/7ba07551dfcd4ef9a87b8f0d9eb8b91fabcb41b3.patch"; + sha256 = "ebbLILncq1hAZTBMsLm+vDGw6j0iQ0crGyhzyLZQgKA="; + }) + ] ++ lib.optionals stdenv.hostPlatform.isMusl [ # Make netgroup support optional (musl does not have it) # Upstream MR: https://gitlab.freedesktop.org/polkit/polkit/merge_requests/10 # We use the version of the patch that Alpine uses successfully. (fetchpatch { name = "make-innetgr-optional.patch"; - url = "https://git.alpinelinux.org/aports/plain/main/polkit/make-innetgr-optional.patch?id=391e7de6ced1a96c2dac812e0b12f1d7e0ea705e"; - sha256 = "1p9qqqhnrfyjvvd50qh6vpl256kyfblm1qnhz5pm09klrl1bh1n4"; + url = "https://git.alpinelinux.org/aports/plain/community/polkit/make-innetgr-optional.patch?id=424ecbb6e9e3a215c978b58c05e5c112d88dddfc"; + sha256 = "0iyiksqk29sizwaa4623bv683px1fny67639qpb1him89hza00wy"; }) ]; - postPatch = lib.optionalString stdenv.isDarwin '' - sed -i -e "s/-Wl,--as-needed//" configure.ac - ''; - - outputs = [ "bin" "dev" "out" ]; # small man pages in $bin + nativeBuildInputs = [ + glib + gtk-doc + pkg-config + gettext + meson + ninja + perl + rsync + (python3.withPackages (pp: with pp; [ + dbus-python + (python-dbusmock.overridePythonAttrs (attrs: { + # Avoid dependency cycle. + doCheck = false; + })) + ])) + + # man pages + libxslt + docbook-xsl-nons + docbook_xml_dtd_412 + ]; - nativeBuildInputs = - [ glib gtk-doc pkg-config intltool perl ] - ++ [ libxslt docbook_xsl docbook_xml_dtd_412 ]; # man pages - buildInputs = - [ expat pam spidermonkey_78 ] + buildInputs = [ + expat + pam + spidermonkey_78 + ] ++ lib.optionals stdenv.isLinux [ # On Linux, fall back to elogind when systemd support is off. - ++ lib.optional stdenv.isLinux (if useSystemd then systemd else elogind) - ++ lib.optional withIntrospection gobject-introspection; + (if useSystemd then systemd else elogind) + ] ++ lib.optionals withIntrospection [ + gobject-introspection + ]; propagatedBuildInputs = [ glib # in .pc Requires ]; - preConfigure = '' - chmod +x test/mocklibc/bin/mocklibc{,-test}.in - patchShebangs . + checkInputs = [ + dbus + ]; + + mesonFlags = [ + "--datadir=${system}/share" + "--sysconfdir=/etc" + "-Dsystemdsystemunitdir=${placeholder "out"}/etc/systemd/system" + "-Dpolkitd_user=polkituser" #TODO? <nixos> config.ids.uids.polkituser + "-Dos_type=redhat" # only affects PAM includes + "-Dintrospection=${lib.boolToString withIntrospection}" + "-Dtests=${lib.boolToString doCheck}" + "-Dgtk_doc=${lib.boolToString true}" + "-Dman=true" + ] ++ lib.optionals stdenv.isLinux [ + "-Dsession_tracking=${if useSystemd then "libsystemd-login" else "libelogind"}" + ]; + + # HACK: We want to install policy files files to $out/share but polkit + # should read them from /run/current-system/sw/share on a NixOS system. + # Similarly for config files in /etc. + # With autotools, it was possible to override Make variables + # at install time but Meson does not support this + # so we need to convince it to install all files to a temporary + # location using DESTDIR and then move it to proper one in postInstall. + DESTDIR = "${placeholder "out"}/dest"; + + inherit doCheck; + + postPatch = '' + patchShebangs test/polkitbackend/polkitbackendjsauthoritytest-wrapper.py # ‘libpolkit-agent-1.so’ should call the setuid wrapper on # NixOS. Hard-coding the path is kinda ugly. Maybe we can just @@ -69,45 +147,40 @@ stdenv.mkDerivation rec { substituteInPlace test/data/etc/polkit-1/rules.d/10-testing.rules \ --replace /bin/true ${coreutils}/bin/true \ --replace /bin/false ${coreutils}/bin/false - - '' + lib.optionalString useSystemd /* bogus chroot detection */ '' - sed '/libsystemd autoconfigured/s/.*/:/' -i configure ''; - configureFlags = [ - "--datadir=${system}/share" - "--sysconfdir=/etc" - "--with-systemdsystemunitdir=${placeholder "out"}/etc/systemd/system" - "--with-polkitd-user=polkituser" #TODO? <nixos> config.ids.uids.polkituser - "--with-os-type=NixOS" # not recognized but prevents impurities on non-NixOS - (if withIntrospection then "--enable-introspection" else "--disable-introspection") - ] ++ lib.optional (!doCheck) "--disable-test"; - - makeFlags = [ - "INTROSPECTION_GIRDIR=${placeholder "out"}/share/gir-1.0" - "INTROSPECTION_TYPELIBDIR=${placeholder "out"}/lib/girepository-1.0" - ]; - - installFlags = [ - "datadir=${placeholder "out"}/share" - "sysconfdir=${placeholder "out"}/etc" - ]; + postConfigure = '' + # Unpacked by meson + chmod +x subprojects/mocklibc-1.0/bin/mocklibc + patchShebangs subprojects/mocklibc-1.0/bin/mocklibc + ''; - inherit doCheck; - checkInputs = [ dbus ]; checkPhase = '' runHook preCheck - # unfortunately this test needs python-dbusmock, but python-dbusmock needs polkit, - # leading to a circular dependency - substituteInPlace test/Makefile --replace polkitbackend "" - # tests need access to the system bus - dbus-run-session --config-file=${./system_bus.conf} -- sh -c 'DBUS_SYSTEM_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS make check' + dbus-run-session --config-file=${./system_bus.conf} -- sh -c 'DBUS_SYSTEM_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS meson test --print-errorlogs' runHook postCheck ''; + postInstall = '' + # Move stuff from DESTDIR to proper location. + # We use rsync to merge the directories. + rsync --archive "${DESTDIR}/etc" "$out" + rm --recursive "${DESTDIR}/etc" + rsync --archive "${DESTDIR}${system}"/* "$out" + rm --recursive "${DESTDIR}${system}"/* + rmdir --parents --ignore-fail-on-non-empty "${DESTDIR}${system}" + for o in $outputs; do + rsync --archive "${DESTDIR}/''${!o}" "$(dirname "''${!o}")" + rm --recursive "${DESTDIR}/''${!o}" + done + # Ensure the DESTDIR is removed. + destdirContainer="$(dirname "${DESTDIR}")" + pushd "$destdirContainer"; rmdir --parents "''${DESTDIR##$destdirContainer/}${builtins.storeDir}"; popd + ''; + meta = with lib; { homepage = "http://www.freedesktop.org/wiki/Software/polkit"; description = "A toolkit for defining and handling the policy that allows unprivileged processes to speak to privileged processes"; |