diff options
author | Alyssa Ross <hi@alyssa.is> | 2023-08-08 16:04:42 +0000 |
---|---|---|
committer | Alyssa Ross <hi@alyssa.is> | 2023-08-13 06:35:37 +0000 |
commit | 12aaa58dac35800b5b7d77f81cf2a87c21ee55da (patch) | |
tree | be0add9e5c22a85d20b5d78206aa74f956eb2a1b /nixpkgs/pkgs/development/libraries/libiconv | |
parent | 45892a5591202f75a1c2f1ca7c62a92c7566e3c5 (diff) | |
parent | 5a8e9243812ba528000995b294292d3b5e120947 (diff) | |
download | nixlib-12aaa58dac35800b5b7d77f81cf2a87c21ee55da.tar nixlib-12aaa58dac35800b5b7d77f81cf2a87c21ee55da.tar.gz nixlib-12aaa58dac35800b5b7d77f81cf2a87c21ee55da.tar.bz2 nixlib-12aaa58dac35800b5b7d77f81cf2a87c21ee55da.tar.lz nixlib-12aaa58dac35800b5b7d77f81cf2a87c21ee55da.tar.xz nixlib-12aaa58dac35800b5b7d77f81cf2a87c21ee55da.tar.zst nixlib-12aaa58dac35800b5b7d77f81cf2a87c21ee55da.zip |
Merge branch 'nixos-unstable' of https://github.com/NixOS/nixpkgs
Conflicts: nixpkgs/pkgs/applications/window-managers/sway/default.nix nixpkgs/pkgs/build-support/go/module.nix nixpkgs/pkgs/build-support/rust/build-rust-package/default.nix nixpkgs/pkgs/development/libraries/mesa/default.nix nixpkgs/pkgs/servers/dict/dictd-db.nix Link: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/issues/391
Diffstat (limited to 'nixpkgs/pkgs/development/libraries/libiconv')
-rw-r--r-- | nixpkgs/pkgs/development/libraries/libiconv/default.nix | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/nixpkgs/pkgs/development/libraries/libiconv/default.nix b/nixpkgs/pkgs/development/libraries/libiconv/default.nix index a6481970ef27..91b0df75f87b 100644 --- a/nixpkgs/pkgs/development/libraries/libiconv/default.nix +++ b/nixpkgs/pkgs/development/libraries/libiconv/default.nix @@ -1,6 +1,7 @@ { fetchurl, stdenv, lib , enableStatic ? stdenv.hostPlatform.isStatic , enableShared ? !stdenv.hostPlatform.isStatic +, enableDarwinABICompat ? false }: # assert !stdenv.hostPlatform.isLinux || stdenv.hostPlatform != stdenv.buildPlatform; # TODO: improve on cross @@ -28,8 +29,35 @@ stdenv.mkDerivation rec { '' + lib.optionalString (!enableShared) '' sed -i -e '/preload/d' Makefile.in + '' + # The system libiconv is based on libiconv 1.11 with some ABI differences. The following changes + # build a compatible libiconv on Darwin, allowing it to be sustituted in place of the system one + # using `install_name_tool`. This removes the need to for a separate, Darwin-specific libiconv + # derivation and allows Darwin to benefit from upstream updates and fixes. + + lib.optionalString enableDarwinABICompat '' + for iconv_h_in in iconv.h.in iconv.h.build.in; do + substituteInPlace "include/$iconv_h_in" \ + --replace "#define iconv libiconv" "" \ + --replace "#define iconv_close libiconv_close" "" \ + --replace "#define iconv_open libiconv_open" "" \ + --replace "#define iconv_open_into libiconv_open_into" "" \ + --replace "#define iconvctl libiconvctl" "" \ + --replace "#define iconvlist libiconvlist" "" + done ''; + # This is hacky, but `libiconv.dylib` needs to reexport `libcharset.dylib` to match the behavior + # of the system libiconv on Darwin. Trying to do this by modifying the `Makefile` results in an + # error linking `iconv` because `libcharset.dylib` is not at its final path yet. Avoid the error + # by building without the reexport then clean and rebuild `libiconv.dylib` with the reexport. + # + # For an explanation why `libcharset.dylib` is reexported, see: + # https://github.com/apple-oss-distributions/libiconv/blob/a167071feb7a83a01b27ec8d238590c14eb6faff/xcodeconfig/libiconv.xcconfig + postBuild = lib.optionalString enableDarwinABICompat '' + make clean -C lib + NIX_CFLAGS_COMPILE+=" -Wl,-reexport-lcharset -L. " make -C lib -j$NIX_BUILD_CORES SHELL=$SHELL + ''; + configureFlags = [ (lib.enableFeature enableStatic "static") (lib.enableFeature enableShared "shared") |