diff options
author | Alyssa Ross <hi@alyssa.is> | 2023-09-12 08:14:37 +0000 |
---|---|---|
committer | Alyssa Ross <hi@alyssa.is> | 2023-09-12 08:14:37 +0000 |
commit | 7d648ac22d941d0c7efdd987315ae0ddf9932ba0 (patch) | |
tree | 51a3e8126722c5a52a9a1e7e40b4eeaf4610db0b /nixpkgs/maintainers | |
parent | aa4353b499e6950b7333578f936455a628145c31 (diff) | |
parent | db9208ab987cdeeedf78ad9b4cf3c55f5ebd269b (diff) | |
download | nixlib-7d648ac22d941d0c7efdd987315ae0ddf9932ba0.tar nixlib-7d648ac22d941d0c7efdd987315ae0ddf9932ba0.tar.gz nixlib-7d648ac22d941d0c7efdd987315ae0ddf9932ba0.tar.bz2 nixlib-7d648ac22d941d0c7efdd987315ae0ddf9932ba0.tar.lz nixlib-7d648ac22d941d0c7efdd987315ae0ddf9932ba0.tar.xz nixlib-7d648ac22d941d0c7efdd987315ae0ddf9932ba0.tar.zst nixlib-7d648ac22d941d0c7efdd987315ae0ddf9932ba0.zip |
Merge branch 'nixos-unstable' of https://github.com/NixOS/nixpkgs
Diffstat (limited to 'nixpkgs/maintainers')
-rw-r--r-- | nixpkgs/maintainers/README.md | 63 | ||||
-rw-r--r-- | nixpkgs/maintainers/maintainer-list.nix | 72 |
2 files changed, 119 insertions, 16 deletions
diff --git a/nixpkgs/maintainers/README.md b/nixpkgs/maintainers/README.md index e12881851925..5bb9c58db024 100644 --- a/nixpkgs/maintainers/README.md +++ b/nixpkgs/maintainers/README.md @@ -1,10 +1,63 @@ # Nixpkgs Maintainers -The *Nixpkgs maintainers* are people who have assigned themselves to -maintain specific individual packages. We encourage people who care -about a package to assign themselves as a maintainer. When a pull -request is made against a package, OfBorg will notify the appropriate -maintainer(s). +Unlike other packaging ecosystems, the maintainer doesn't have exclusive +control over the packages and modules they maintain. This more fluid approach +is one reason why we scale to so many packages. + +## Definition and role of the maintainer + +The main responsibility of a maintainer is to keep the packages they maintain +in a functioning state, and keep up with updates. In order to do that, they +are empowered to make decisions over the packages they maintain. + +That being said, the maintainer is not alone proposing changes to the +packages. Anybody (both bots and humans) can send PRs to bump or tweak the +package. + +We also allow other non-maintainer committers to merge changes to the package, +provided enough time and priority has been given to the maintainer. + +For most packages, we expect committers to wait at least a week before merging +changes not endorsed by a package maintainer (which may be themselves). This should leave enough time +for the maintainers to provide feedback. + +For critical packages, this convention needs to be negotiated with the +maintainer. A critical package is one that causes mass-rebuild, or where an +author is listed in the [`CODEOWNERS`](../.github/CODEOWNERS) file. + +In case of critical security updates, the [security team](https://nixos.org/community/teams/security) might override these +heuristics in order to get the fixes in as fast as possible. + +In case of conflict, the maintainer takes priority and is allowed to revert +the changes. This can happen for example if the maintainer was on holiday. + +### How to become a maintainer + +We encourage people who care about a package to assign themselves as a +maintainer. Commit access to the Nixpkgs repository is not required for that. + +In order to do so, add yourself to the +[`maintainer-list.nix`](./maintainer-list.nix), and then to the desired +package's `meta.maintainers` list, and send a PR with the changes. + +### How to lose maintainer status + +Maintainers who have become inactive on a given package can be removed. This +helps us keep an accurate view of the state of maintenance in Nixpkgs. + +The inactivity measure is currently not strictly enforced. We would typically +look at it if we notice that the author hasn't reacted to package-related +notifications for more than 3 months. + +Removing the maintainer happens by making a PR on the package, adding that +person as a reviewer, and then waiting a week for a reaction. + +The maintainer is welcome to come back at any time. + +### Tools for maintainers + +When a pull request is made against a package, OfBorg will notify the +appropriate maintainer(s). ## Reviewing contributions diff --git a/nixpkgs/maintainers/maintainer-list.nix b/nixpkgs/maintainers/maintainer-list.nix index 79cca0e7b090..1e6fe5abc5b4 100644 --- a/nixpkgs/maintainers/maintainer-list.nix +++ b/nixpkgs/maintainers/maintainer-list.nix @@ -132,6 +132,12 @@ github = "13r0ck"; githubId = 58987761; }; + _21eleven = { + name = "Noah Lidell"; + email = "noahlidell@gmail.com"; + github = "21eleven"; + githubId = 8813855; + }; _2gn = { name = "Hiram Tanner"; github = "2gn"; @@ -5535,11 +5541,11 @@ matrix = "@felipeqq2:pub.solar"; }; felixalbrigtsen = { - email = "felixalbrigtsen@gmail.com"; + email = "felix@albrigtsen.it"; github = "felixalbrigtsen"; githubId = 64613093; name = "Felix Albrigtsen"; - matrix = "@felixalb:pvv.ntnu.no"; + matrix = "@felixalb:feal.no"; }; felixscheinost = { name = "Felix Scheinost"; @@ -5732,6 +5738,12 @@ githubId = 5918766; name = "Franz Thoma"; }; + fogti = { + name = "Alain Fogtia Zscheile"; + email = "fogti+devel@ytrizja.de"; + github = "fogti"; + githubId = 1618343; + }; foo-dogsquared = { email = "foo.dogsquared@gmail.com"; github = "foo-dogsquared"; @@ -6705,6 +6717,12 @@ githubId = 1379411; name = "Georg Haas"; }; + hbjydev = { + email = "hayden@kuraudo.io"; + github = "hbjydev"; + githubId = 22327045; + name = "Hayden Young"; + }; hbunke = { email = "bunke.hendrik@gmail.com"; github = "hbunke"; @@ -9843,6 +9861,13 @@ githubId = 725613; name = "Linus Arver"; }; + linuxissuper = { + email = "m+nix@linuxistcool.de"; + matrix = "@m:linuxistcool.de"; + github = "linuxissuper"; + githubId = 74221543; + name = "Moritz Goltdammer"; + }; lionello = { email = "lio@lunesu.com"; github = "lionello"; @@ -10485,6 +10510,12 @@ githubId = 40720523; name = "MangoIV"; }; + manipuladordedados = { + email = "manipuladordedados@gmail.com"; + github = "manipuladordedados"; + githubId = 1189862; + name = "Valter Nazianzeno"; + }; manojkarthick = { email = "smanojkarthick@gmail.com"; github = "manojkarthick"; @@ -10883,6 +10914,12 @@ githubId = 613740; name = "Martin Baillie"; }; + mbalatsko = { + email = "mbalatsko@gmail.com"; + github = "mbalatsko"; + githubId = 15967073; + name = "Maksym Balatsko"; + }; mbbx6spp = { email = "me@susanpotter.net"; github = "mbbx6spp"; @@ -12866,6 +12903,12 @@ githubId = 915970; name = "Austin Platt"; }; + onur-ozkan = { + name = "Onur Ozkan"; + email = "contact@onurozkan.dev"; + github = "onur-ozkan"; + githubId = 39852038; + }; ony = { name = "Mykola Orliuk"; email = "virkony@gmail.com"; @@ -13838,6 +13881,13 @@ fingerprint = "DD54 130B ABEC B65C 1F6B 2A38 8312 4F97 A318 EA18"; }]; }; + p-rintz = { + email = "nix@rintz.net"; + github = "p-rintz"; + githubId = 13933258; + name = "Philipp Rintz"; + matrix = "@philipp:srv.icu"; + }; ProducerMatt = { name = "Matthew Pherigo"; email = "ProducerMatt42@gmail.com"; @@ -15919,6 +15969,15 @@ github = "syvb"; githubId = 10530973; }; + smona = { + name = "Mel Bourgeois"; + email = "mason.bourgeois@gmail.com"; + github = "Smona"; + githubId = 7091399; + keys = [{ + fingerprint = "897E 6BE3 0345 B43D CADD 05B7 290F CF08 1AED B3EC"; + }]; + }; sna = { email = "abouzahra.9@wright.edu"; github = "S-NA"; @@ -19193,15 +19252,6 @@ githubId = 8100652; name = "David Mell"; }; - zseri = { - name = "zseri"; - email = "zseri.devel@ytrizja.de"; - github = "fogti"; - githubId = 1618343; - keys = [{ - fingerprint = "7AFB C595 0D3A 77BD B00F 947B 229E 63AE 5644 A96D"; - }]; - }; ztzg = { email = "dd@crosstwine.com"; github = "ztzg"; |