about summary refs log tree commit diff
path: root/nixos
diff options
context:
space:
mode:
authorvolth <volth@volth.com>2019-09-06 21:13:28 +0000
committerGitHub <noreply@github.com>2019-09-06 21:13:28 +0000
commitefccc442d97d9e6df8c1bb2b28ddcb39f45c808f (patch)
treec3b6458e25f27a083f9ff652e31c59c5c2ae42d5 /nixos
parent3387a16c2f938f825a4ca29e350b1a21cacc10d7 (diff)
downloadnixlib-efccc442d97d9e6df8c1bb2b28ddcb39f45c808f.tar
nixlib-efccc442d97d9e6df8c1bb2b28ddcb39f45c808f.tar.gz
nixlib-efccc442d97d9e6df8c1bb2b28ddcb39f45c808f.tar.bz2
nixlib-efccc442d97d9e6df8c1bb2b28ddcb39f45c808f.tar.lz
nixlib-efccc442d97d9e6df8c1bb2b28ddcb39f45c808f.tar.xz
nixlib-efccc442d97d9e6df8c1bb2b28ddcb39f45c808f.tar.zst
nixlib-efccc442d97d9e6df8c1bb2b28ddcb39f45c808f.zip
network-interfaces.nix: escape '.' in interface names passed to sysctl
Diffstat (limited to 'nixos')
-rw-r--r--nixos/modules/tasks/network-interfaces.nix8
1 files changed, 4 insertions, 4 deletions
diff --git a/nixos/modules/tasks/network-interfaces.nix b/nixos/modules/tasks/network-interfaces.nix
index 5bf7b0d227f0..43a1c0fe9026 100644
--- a/nixos/modules/tasks/network-interfaces.nix
+++ b/nixos/modules/tasks/network-interfaces.nix
@@ -967,9 +967,9 @@ in
       "net.ipv6.conf.default.disable_ipv6" = mkDefault (!cfg.enableIPv6);
       "net.ipv6.conf.all.forwarding" = mkDefault (any (i: i.proxyARP) interfaces);
     } // listToAttrs (flip concatMap (filter (i: i.proxyARP) interfaces)
-        (i: forEach [ "4" "6" ] (v: nameValuePair "net.ipv${v}.conf.${i.name}.proxy_arp" true)))
+        (i: forEach [ "4" "6" ] (v: nameValuePair "net.ipv${v}.conf.${replaceChars ["."] ["/"] i.name}.proxy_arp" true)))
       // listToAttrs (forEach (filter (i: i.preferTempAddress) interfaces)
-        (i: nameValuePair "net.ipv6.conf.${i.name}.use_tempaddr" 2));
+        (i: nameValuePair "net.ipv6.conf.${replaceChars ["."] ["/"] i.name}.use_tempaddr" 2));
 
     # Capabilities won't work unless we have at-least a 4.3 Linux
     # kernel because we need the ambient capability
@@ -1092,7 +1092,7 @@ in
         destination = "/etc/udev/rules.d/98-${name}";
         text = ''
           # enable and prefer IPv6 privacy addresses by default
-          ACTION=="add", SUBSYSTEM=="net", RUN+="${pkgs.procps}/bin/sysctl net.ipv6.conf.%k.use_tempaddr=2"
+          ACTION=="add", SUBSYSTEM=="net", RUN+="echo 2 > /proc/sys/net/ipv6/conf/%k/use_tempaddr"
         '';
       })
       (pkgs.writeTextFile rec {
@@ -1100,7 +1100,7 @@ in
         destination = "/etc/udev/rules.d/99-${name}";
         text = concatMapStrings (i: ''
           # enable IPv6 privacy addresses but prefer EUI-64 addresses for ${i.name}
-          ACTION=="add", SUBSYSTEM=="net", RUN+="${pkgs.procps}/bin/sysctl net.ipv6.conf.${i.name}.use_tempaddr=1"
+          ACTION=="add", SUBSYSTEM=="net", RUN+="${pkgs.procps}/bin/sysctl net.ipv6.conf.${replaceChars ["."] ["/"] i.name}.use_tempaddr=1"
         '') (filter (i: !i.preferTempAddress) interfaces);
       })
     ] ++ lib.optional (cfg.wlanInterfaces != {})