diff options
| author | DavHau <42246742+DavHau@users.noreply.github.com> | 2019-11-13 03:41:30 +0700 |
|---|---|---|
| committer | markuskowa <markus.kowalewski@gmail.com> | 2019-11-12 21:41:30 +0100 |
| commit | 331f45f7bb5a90ce2b5516a9ae34da566f54e69c (patch) | |
| tree | d91cbf5bfa4e82377a824e32bff6bdfa8b14462f /doc/contributing | |
| parent | b252047216f89d6b3074ce8e6a40dbb75286b327 (diff) | |
| download | nixlib-331f45f7bb5a90ce2b5516a9ae34da566f54e69c.tar nixlib-331f45f7bb5a90ce2b5516a9ae34da566f54e69c.tar.gz nixlib-331f45f7bb5a90ce2b5516a9ae34da566f54e69c.tar.bz2 nixlib-331f45f7bb5a90ce2b5516a9ae34da566f54e69c.tar.lz nixlib-331f45f7bb5a90ce2b5516a9ae34da566f54e69c.tar.xz nixlib-331f45f7bb5a90ce2b5516a9ae34da566f54e69c.tar.zst nixlib-331f45f7bb5a90ce2b5516a9ae34da566f54e69c.zip | |
update contributors documentation for nix-review (#73217)
Useful for newcomers who want to do their review after committing and then stumbling across the PR checklist. * replace nix-shell with nix run
Diffstat (limited to 'doc/contributing')
| -rw-r--r-- | doc/contributing/submitting-changes.xml | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/doc/contributing/submitting-changes.xml b/doc/contributing/submitting-changes.xml index f09711624117..0a652aef9232 100644 --- a/doc/contributing/submitting-changes.xml +++ b/doc/contributing/submitting-changes.xml @@ -298,14 +298,17 @@ Additional information. <para> review changes from pull request number 12345: -<screen>nix-shell -p nix-review --run "nix-review pr 12345"</screen> +<screen>nix run nixpkgs.nix-review -c nix-review pr 12345</screen> </para> <para> review uncommitted changes: -<screen>nix-shell -p nix-review --run "nix-review wip"</screen> +<screen>nix run nixpkgs.nix-review -c nix-review wip</screen> </para> - </section> + + <para> + review changes from last commit: +<screen>nix run nixpkgs.nix-review -c nix-review rev HEAD</screen> <section xml:id="submitting-changes-tested-execution"> <title>Tested execution of all binary files (usually in <filename>./result/bin/</filename>)</title> |