diff options
| author | Matthias Beyer <mail@beyermatthias.de> | 2023-08-08 21:58:55 +0200 |
|---|---|---|
| committer | Matthias Beyer <mail@beyermatthias.de> | 2023-09-04 10:29:20 +0200 |
| commit | aa25691630cb54c5c3d261198cb838bbce2afb5c (patch) | |
| tree | fca8409e13843cbb66bad9d108d6378111938827 /CONTRIBUTING.md | |
| parent | 81a8aa7652a5046580ee7ee6ce51d83716164420 (diff) | |
| download | nixlib-aa25691630cb54c5c3d261198cb838bbce2afb5c.tar nixlib-aa25691630cb54c5c3d261198cb838bbce2afb5c.tar.gz nixlib-aa25691630cb54c5c3d261198cb838bbce2afb5c.tar.bz2 nixlib-aa25691630cb54c5c3d261198cb838bbce2afb5c.tar.lz nixlib-aa25691630cb54c5c3d261198cb838bbce2afb5c.tar.xz nixlib-aa25691630cb54c5c3d261198cb838bbce2afb5c.tar.zst nixlib-aa25691630cb54c5c3d261198cb838bbce2afb5c.zip | |
CONTRIBUTING: Add note about how to commit new maintainers-list.nix entry
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 177e6a4a687e..616fd4c22013 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -535,6 +535,11 @@ To get a sense for what changes are considered mass rebuilds, see [previously me The old config generation system used impure shell scripts and could break in specific circumstances (see #1234). + When adding yourself as maintainer, in the same pull request, make a separate + commit with the message `maintainers: add <handle>`. + Add the commit before those making changes to the package or module. + See [Nixpkgs Maintainers](../maintainers/README.md) for details. + ### Writing good commit messages In addition to writing properly formatted commit messages, it's important to include relevant information so other developers can later understand *why* a change was made. While this information usually can be found by digging code, mailing list/Discourse archives, pull request discussions or upstream changes, it may require a lot of work. |