diff options
author | Matthew Bauer <mjbauer95@gmail.com> | 2018-07-04 15:05:54 -0400 |
---|---|---|
committer | Matthew Bauer <mjbauer95@gmail.com> | 2018-07-04 15:08:07 -0400 |
commit | e8303d2baf730dbd73f8f5b06a878c525d55b2b2 (patch) | |
tree | 167816b475b4dce6d79235ce7b09a5bf177c103f | |
parent | 1dca19f057dbb60bafb0f572e7c343c13666ba50 (diff) | |
download | nixlib-e8303d2baf730dbd73f8f5b06a878c525d55b2b2.tar nixlib-e8303d2baf730dbd73f8f5b06a878c525d55b2b2.tar.gz nixlib-e8303d2baf730dbd73f8f5b06a878c525d55b2b2.tar.bz2 nixlib-e8303d2baf730dbd73f8f5b06a878c525d55b2b2.tar.lz nixlib-e8303d2baf730dbd73f8f5b06a878c525d55b2b2.tar.xz nixlib-e8303d2baf730dbd73f8f5b06a878c525d55b2b2.tar.zst nixlib-e8303d2baf730dbd73f8f5b06a878c525d55b2b2.zip |
libuv: reenable tests on macOS
I want these tests to run because libuv is very important to lots of things in Nixpkgs. I have a very large list of tests to disable for now just to be on the safe side. For the record this is definitely a libuv issue - their tests should be robust - but this is a safety precaution for now.
-rw-r--r-- | pkgs/development/libraries/libuv/default.nix | 23 |
1 files changed, 17 insertions, 6 deletions
diff --git a/pkgs/development/libraries/libuv/default.nix b/pkgs/development/libraries/libuv/default.nix index f45001c21fe3..cc92ff3fdd5c 100644 --- a/pkgs/development/libraries/libuv/default.nix +++ b/pkgs/development/libraries/libuv/default.nix @@ -20,8 +20,22 @@ stdenv.mkDerivation rec { "getaddrinfo_fail" "getaddrinfo_fail_sync" "threadpool_multiple_event_loops" # times out on slow machines ] - # sometimes: timeout (no output), failed uv_listen - ++ stdenv.lib.optionals stdenv.isDarwin [ "process_title" "emfile" ]; + # Sometimes: timeout (no output), failed uv_listen. Someone + # should report these failures to libuv team. There tests should + # be much more robust. + ++ stdenv.lib.optionals stdenv.isDarwin [ + "process_title" "emfile" "poll_duplex" "poll_unidirectional" + "ipc_listen_before_write" "ipc_listen_after_write" "ipc_tcp_connection" + "tcp_alloc_cb_fail" "tcp_ping_pong" "tcp_ref3" "tcp_ref4" + "tcp_bind6_error_inval" "tcp_bind6_error_addrinuse" "tcp_read_stop" + "tcp_unexpected_read" "tcp_write_to_half_open_connection" + "tcp_oob" "tcp_close_accept" "tcp_create_early_accept" + "tcp_create_early" "tcp_close" "tcp_bind_error_inval" + "tcp_bind_error_addrinuse" "tcp_shutdown_after_write" + "tcp_open" "tcp_write_queue_order" "tcp_try_write" "tcp_writealot" + "multiple_listen" "delayed_accept" + "shutdown_close_tcp" "shutdown_eof" "shutdown_twice" "callback_stack" + ]; tdRegexp = lib.concatStringsSep "\\|" toDisable; in lib.optionalString doCheck '' sed '/${tdRegexp}/d' -i test/test-list.h @@ -35,10 +49,7 @@ stdenv.mkDerivation rec { enableParallelBuilding = true; - # These should be turned back on, but see https://github.com/NixOS/nixpkgs/issues/23651 - # For now the tests are just breaking large swaths of the nixpkgs binary cache for Darwin, - # and I'd rather have everything else work at all than have stronger assurance here. - doCheck = !stdenv.isDarwin; + doCheck = true; meta = with lib; { description = "A multi-platform support library with a focus on asynchronous I/O"; |