about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFrederik Rietdijk <fridh@fridh.nl>2016-02-17 19:42:43 +0100
committerFrederik Rietdijk <fridh@fridh.nl>2016-02-17 19:42:43 +0100
commitc44176237af93f4497aaec8e4588ff2e896b0df4 (patch)
treef9dbf97077c66c91293019a3c82ec68618391dca
parent74bda15a94490feef13dd7313f64255acc3d6af3 (diff)
downloadnixlib-c44176237af93f4497aaec8e4588ff2e896b0df4.tar
nixlib-c44176237af93f4497aaec8e4588ff2e896b0df4.tar.gz
nixlib-c44176237af93f4497aaec8e4588ff2e896b0df4.tar.bz2
nixlib-c44176237af93f4497aaec8e4588ff2e896b0df4.tar.lz
nixlib-c44176237af93f4497aaec8e4588ff2e896b0df4.tar.xz
nixlib-c44176237af93f4497aaec8e4588ff2e896b0df4.tar.zst
nixlib-c44176237af93f4497aaec8e4588ff2e896b0df4.zip
pythonPackages.fs: build with all Python versions
and add updated explanation of why tests are disabled.
See also https://github.com/NixOS/nixpkgs/pull/13066
-rw-r--r--pkgs/top-level/python-packages.nix9
1 files changed, 5 insertions, 4 deletions
diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index 12a74cf94417..56572ab74308 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -8960,10 +8960,11 @@ in modules // {
       ${python.interpreter} -m unittest discover
     '';
 
-    # Judging from SyntaxError
-    disabled = isPy3k;
-
-    # Lots of errors. Likely due to being in a chroot
+    # Because 2to3 is used the tests in $out need to be run.
+    # Both when using unittest and pytest this resulted in many errors,
+    # some Python byte/str errors, and others specific to resources tested.
+    # Failing tests due to the latter is to be expected with this type of package.
+    # Tests are therefore disabled.
     doCheck = false;
 
     meta = {