about summary refs log tree commit diff
diff options
context:
space:
mode:
authorPeter Simons <simons@cryp.to>2010-12-07 11:41:25 +0000
committerPeter Simons <simons@cryp.to>2010-12-07 11:41:25 +0000
commitbaa91501304dec0e6091411210f3f4a2a19a923a (patch)
tree6ff3cb86c3624556fe7c7ec71091fd5f0d17fcd8
parent04ec671c8a809d987eeb79d69dd51377f907f29a (diff)
downloadnixlib-baa91501304dec0e6091411210f3f4a2a19a923a.tar
nixlib-baa91501304dec0e6091411210f3f4a2a19a923a.tar.gz
nixlib-baa91501304dec0e6091411210f3f4a2a19a923a.tar.bz2
nixlib-baa91501304dec0e6091411210f3f4a2a19a923a.tar.lz
nixlib-baa91501304dec0e6091411210f3f4a2a19a923a.tar.xz
nixlib-baa91501304dec0e6091411210f3f4a2a19a923a.tar.zst
nixlib-baa91501304dec0e6091411210f3f4a2a19a923a.zip
pkgs/development/tools/build-managers/scons: cosmetic build improvements
 - The flag "--mandir" has no effect with setup.py. Instead, "--install-data"
   must be used.

 - Don't generate wrappers for trivial symlink aliases in bin.

 - Prefer symlinks over hard-links.

 - The dependencies of this expression don't need to be propagated.

svn path=/nixpkgs/trunk/; revision=25021
-rw-r--r--pkgs/development/tools/build-managers/scons/default.nix9
1 files changed, 4 insertions, 5 deletions
diff --git a/pkgs/development/tools/build-managers/scons/default.nix b/pkgs/development/tools/build-managers/scons/default.nix
index 4e9edbde33a6..9d6ab6ba8159 100644
--- a/pkgs/development/tools/build-managers/scons/default.nix
+++ b/pkgs/development/tools/build-managers/scons/default.nix
@@ -13,16 +13,15 @@ stdenv.mkDerivation {
     sha256 = "0qk74nrnm9qlijrq6gmy8cyhjgp0gis4zx44divnr8n487d5308a";
   };
 
+  buildInputs = [python makeWrapper];
+
   preConfigure = ''
-    configureFlags="--mandir=$out/share/man"
     for i in "script/"*; do
      substituteInPlace $i --replace "/usr/bin/env python" "${python}/bin/python"
     done
   '';
-
-  propagatedBuildInputs = [python makeWrapper];
-  buildPhase = "python setup.py install --prefix=$out --install-lib=$(toPythonPath $out) --hardlink-scons -O1";
-  installPhase = "for n in $out/bin/*; do wrapProgram $n --suffix PYTHONPATH ':' \"$(toPythonPath $out)\"; done";
+  buildPhase = "python setup.py install --prefix=$out --install-data=$out/share --install-lib=$(toPythonPath $out) --symlink-scons -O1";
+  installPhase = "for n in $out/bin/*-${version}; do wrapProgram $n --suffix PYTHONPATH ':' \"$(toPythonPath $out)\"; done";
 
   meta = {
     homepage = "http://scons.org/";