diff options
author | Netix (Espinet François) <dev.espinetfrancois@gmail.com> | 2020-02-20 22:05:20 +0100 |
---|---|---|
committer | Maximilian Bosch <maximilian@mbosch.me> | 2020-02-25 20:36:47 +0100 |
commit | 9f0014b6f209f54b4025a001555dd8e1b1d9ef4f (patch) | |
tree | 0d8880c1fa6b2771e525e8d52260336eeaa709e8 | |
parent | d5db5d12aa93251aa65a8501b4d5be6d1fa6e70d (diff) | |
download | nixlib-9f0014b6f209f54b4025a001555dd8e1b1d9ef4f.tar nixlib-9f0014b6f209f54b4025a001555dd8e1b1d9ef4f.tar.gz nixlib-9f0014b6f209f54b4025a001555dd8e1b1d9ef4f.tar.bz2 nixlib-9f0014b6f209f54b4025a001555dd8e1b1d9ef4f.tar.lz nixlib-9f0014b6f209f54b4025a001555dd8e1b1d9ef4f.tar.xz nixlib-9f0014b6f209f54b4025a001555dd8e1b1d9ef4f.tar.zst nixlib-9f0014b6f209f54b4025a001555dd8e1b1d9ef4f.zip |
grafana: made phantomjs2 optional
On servers especially, phantomjs2 pulls graphical dependencies which is unecessary. This pathes enable the package to be linked/installed without phantomjs2. Phantomjs2 is disabled by default since it has been deprecated in grafana https://grafana.com/docs/grafana/latest/guides/whats-new-in-v6-4/
-rw-r--r-- | nixos/doc/manual/release-notes/rl-2009.xml | 13 | ||||
-rw-r--r-- | pkgs/servers/monitoring/grafana/default.nix | 3 |
2 files changed, 14 insertions, 2 deletions
diff --git a/nixos/doc/manual/release-notes/rl-2009.xml b/nixos/doc/manual/release-notes/rl-2009.xml index d07b7cf49c39..2c407a5130c8 100644 --- a/nixos/doc/manual/release-notes/rl-2009.xml +++ b/nixos/doc/manual/release-notes/rl-2009.xml @@ -59,7 +59,18 @@ <itemizedlist> <listitem> - <para /> + <para> + Grafana is now built without support for phantomjs by default. Phantomjs support has been + <link xlink:href="https://grafana.com/docs/grafana/latest/guides/whats-new-in-v6-4/">deprecated in Grafana</link> + and the <package>phantomjs</package> project is + <link xlink:href="https://github.com/ariya/phantomjs/issues/15344#issue-302015362">currently unmaintained</link>. + It can still be enabled by providing <literal>phantomJsSupport = true</literal> to the package instanciation: +<programlisting>{ + services.grafana.package = pkgs.grafana.overrideAttrs (oldAttrs: rec { + phantomJsSupport = false; + }); +}</programlisting> + </para> </listitem> </itemizedlist> </section> diff --git a/pkgs/servers/monitoring/grafana/default.nix b/pkgs/servers/monitoring/grafana/default.nix index cbb13074afc8..a4a4796a8cdf 100644 --- a/pkgs/servers/monitoring/grafana/default.nix +++ b/pkgs/servers/monitoring/grafana/default.nix @@ -1,4 +1,4 @@ -{ lib, buildGoPackage, fetchurl, fetchFromGitHub, phantomjs2 }: +{ lib, buildGoPackage, fetchurl, fetchFromGitHub, phantomJsSupport ? false, phantomjs2 ? null }: buildGoPackage rec { pname = "grafana"; @@ -31,6 +31,7 @@ buildGoPackage rec { tar -xvf $srcStatic mkdir -p $bin/share/grafana mv grafana-*/{public,conf,tools} $bin/share/grafana/ + '' + lib.optionalString phantomJsSupport '' ln -sf ${phantomjs2}/bin/phantomjs $bin/share/grafana/tools/phantomjs/phantomjs ''; |