about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMaximilian Bosch <maximilian@mbosch.me>2018-11-26 02:25:26 +0100
committerMaximilian Bosch <maximilian@mbosch.me>2018-11-29 02:01:22 +0100
commit9d2160e73bcd96a12235e0d06731964032f136d4 (patch)
tree39f5009e85e88a0a22e0390f2daf060a3f1f66b4
parentfd08b98da90fe1ff064f37f4a54284031a2b7469 (diff)
downloadnixlib-9d2160e73bcd96a12235e0d06731964032f136d4.tar
nixlib-9d2160e73bcd96a12235e0d06731964032f136d4.tar.gz
nixlib-9d2160e73bcd96a12235e0d06731964032f136d4.tar.bz2
nixlib-9d2160e73bcd96a12235e0d06731964032f136d4.tar.lz
nixlib-9d2160e73bcd96a12235e0d06731964032f136d4.tar.xz
nixlib-9d2160e73bcd96a12235e0d06731964032f136d4.tar.zst
nixlib-9d2160e73bcd96a12235e0d06731964032f136d4.zip
pythonPackages.pyftpdlib: skip tests
Although the tests are passing locally, it seems as the excessive
filesystem usage causes several build failures and timeouts in the Hydra
and OfBorg infrastructure:

* https://hydra.nixos.org/build/84374861 (python3 on linux.x86_64)
* https://hydra.nixos.org/build/84368459 (python2 on linux.x86_64)

Some of these tests are failing after several seconds though, but I
couldn't identify a pattern and I'm not overly surprised that a FTP
library has impure tests. However the API seems to be usable in a Python
{2,3} environment, so it should be safe to use even with disabled tests.
-rw-r--r--pkgs/development/python-modules/pyftpdlib/default.nix6
1 files changed, 3 insertions, 3 deletions
diff --git a/pkgs/development/python-modules/pyftpdlib/default.nix b/pkgs/development/python-modules/pyftpdlib/default.nix
index b8f483d3a1dc..254edfb86937 100644
--- a/pkgs/development/python-modules/pyftpdlib/default.nix
+++ b/pkgs/development/python-modules/pyftpdlib/default.nix
@@ -20,9 +20,9 @@ buildPythonPackage rec {
   checkInputs = [ mock psutil ];
   propagatedBuildInputs = [ pyopenssl pysendfile ];
 
-  checkPhase = ''
-    ${python.interpreter} pyftpdlib/test/runner.py
-  '';
+  # impure filesystem-related tests cause timeouts
+  # on Hydra: https://hydra.nixos.org/build/84374861
+  doCheck = false;
 
   meta = with stdenv.lib; {
     homepage = https://github.com/giampaolo/pyftpdlib/;