about summary refs log tree commit diff
diff options
context:
space:
mode:
authorVincent Haupert <vincent@yaxi.tech>2024-01-22 13:55:05 +0100
committerVincent Haupert <vincent@yaxi.tech>2024-02-09 15:14:32 +0100
commit9ad02c831a5dc264940e38a5e9ec2892cd74600e (patch)
tree78ee505a997fcbe5f2696c1b74d5f4a069979172
parentab57ba24cf62c16530ac7bf303c21339235015d1 (diff)
downloadnixlib-9ad02c831a5dc264940e38a5e9ec2892cd74600e.tar
nixlib-9ad02c831a5dc264940e38a5e9ec2892cd74600e.tar.gz
nixlib-9ad02c831a5dc264940e38a5e9ec2892cd74600e.tar.bz2
nixlib-9ad02c831a5dc264940e38a5e9ec2892cd74600e.tar.lz
nixlib-9ad02c831a5dc264940e38a5e9ec2892cd74600e.tar.xz
nixlib-9ad02c831a5dc264940e38a5e9ec2892cd74600e.tar.zst
nixlib-9ad02c831a5dc264940e38a5e9ec2892cd74600e.zip
nixos/github-runner: deprecate module in favor of `github-runners.*`
-rw-r--r--nixos/doc/manual/release-notes/rl-2405.section.md2
-rw-r--r--nixos/modules/module-list.nix1
-rw-r--r--nixos/modules/services/continuous-integration/github-runner.nix25
-rw-r--r--nixos/modules/services/continuous-integration/github-runners.nix4
4 files changed, 6 insertions, 26 deletions
diff --git a/nixos/doc/manual/release-notes/rl-2405.section.md b/nixos/doc/manual/release-notes/rl-2405.section.md
index d3efc1789cdc..4bc6f14acadf 100644
--- a/nixos/doc/manual/release-notes/rl-2405.section.md
+++ b/nixos/doc/manual/release-notes/rl-2405.section.md
@@ -318,6 +318,8 @@ The pre-existing [services.ankisyncd](#opt-services.ankisyncd.enable) has been m
 
 - The `hardware.pulseaudio` module now sets permission of pulse user home directory to 755 when running in "systemWide" mode. It fixes [issue 114399](https://github.com/NixOS/nixpkgs/issues/114399).
 
+- The module `services.github-runner` has been removed. To configure a single GitHub Actions Runner refer to `services.github-runners.*`. Note that this will trigger a new runner registration.
+
 - The `btrbk` module now automatically selects and provides required compression
   program depending on the configured `stream_compress` option. Since this
   replaces the need for the `extraPackages` option, this option will be
diff --git a/nixos/modules/module-list.nix b/nixos/modules/module-list.nix
index 72b6d42591da..ff9af8f70245 100644
--- a/nixos/modules/module-list.nix
+++ b/nixos/modules/module-list.nix
@@ -410,7 +410,6 @@
   ./services/continuous-integration/buildbot/worker.nix
   ./services/continuous-integration/buildkite-agents.nix
   ./services/continuous-integration/gitea-actions-runner.nix
-  ./services/continuous-integration/github-runner.nix
   ./services/continuous-integration/github-runners.nix
   ./services/continuous-integration/gitlab-runner.nix
   ./services/continuous-integration/gocd-agent/default.nix
diff --git a/nixos/modules/services/continuous-integration/github-runner.nix b/nixos/modules/services/continuous-integration/github-runner.nix
deleted file mode 100644
index 27cfee92c75a..000000000000
--- a/nixos/modules/services/continuous-integration/github-runner.nix
+++ /dev/null
@@ -1,25 +0,0 @@
-{ config
-, pkgs
-, lib
-, ...
-}@args:
-
-with lib;
-
-let
-  cfg = config.services.github-runner;
-in
-
-{
-  options.services.github-runner = import ./github-runner/options.nix (args // {
-    # Users don't need to specify options.services.github-runner.name; it will default
-    # to the hostname.
-    includeNameDefault = true;
-  });
-
-  config = mkIf cfg.enable {
-    services.github-runners.${cfg.name} = cfg;
-  };
-
-  meta.maintainers = with maintainers; [ veehaitch newam thomasjm ];
-}
diff --git a/nixos/modules/services/continuous-integration/github-runners.nix b/nixos/modules/services/continuous-integration/github-runners.nix
index ea3f192f6363..3af1c4a49871 100644
--- a/nixos/modules/services/continuous-integration/github-runners.nix
+++ b/nixos/modules/services/continuous-integration/github-runners.nix
@@ -12,6 +12,10 @@ let
 in
 
 {
+  imports = [
+    mkRemovedOptionModule [ "services" "github-runner" ] "Use `services.github-runners.*` instead"
+  ];
+
   options.services.github-runners = mkOption {
     default = {};
     type = with types; attrsOf (submodule { options = import ./github-runner/options.nix (args // {