about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDima <dgoldin+github@protonmail.ch>2019-09-10 18:21:53 +0200
committerDima <dgoldin+github@protonmail.ch>2019-09-10 18:42:30 +0200
commit6f1ad0676fafd70df48c193e6bd1c7956ac26e09 (patch)
tree2d7926810838adab397a2c63ea11b5895889587b
parenta9b1f444b5261106b4381a9ce56b44c6250768e6 (diff)
downloadnixlib-6f1ad0676fafd70df48c193e6bd1c7956ac26e09.tar
nixlib-6f1ad0676fafd70df48c193e6bd1c7956ac26e09.tar.gz
nixlib-6f1ad0676fafd70df48c193e6bd1c7956ac26e09.tar.bz2
nixlib-6f1ad0676fafd70df48c193e6bd1c7956ac26e09.tar.lz
nixlib-6f1ad0676fafd70df48c193e6bd1c7956ac26e09.tar.xz
nixlib-6f1ad0676fafd70df48c193e6bd1c7956ac26e09.tar.zst
nixlib-6f1ad0676fafd70df48c193e6bd1c7956ac26e09.zip
qtwebkit: fixing build / reducing build log size
GCC 8 introduced a new type of warning `-Wclass-memaccess` which
is included in `-Wall`. This warnings spits out *a million* of warnings
like the following:

```
[...]
/build/source/Source/WTF/wtf/Vector.h:128:15: warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of type 'class WTF::RefPtr<WebCore::TransformOperation>' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
         memcpy(dst, src, reinterpret_cast<const char*>(srcEnd) - reinterpret_cast<const char*>(src));
[...]
``

Logs demonstrating the issue:
https://hydra.nixos.org/build/100205478/nixlog/1

While I don't think disabling warnings is the best way to deal with this,
there is alrady precedent for this package and I don't feel confident enough
to either patch or bump this package.

Please view this as a low-friction sub-optimal suggestion in case nobody else
has a better fix.
-rw-r--r--pkgs/development/libraries/qt-5/modules/qtwebkit.nix8
1 files changed, 6 insertions, 2 deletions
diff --git a/pkgs/development/libraries/qt-5/modules/qtwebkit.nix b/pkgs/development/libraries/qt-5/modules/qtwebkit.nix
index d65449023b34..78404ddffa87 100644
--- a/pkgs/development/libraries/qt-5/modules/qtwebkit.nix
+++ b/pkgs/development/libraries/qt-5/modules/qtwebkit.nix
@@ -51,8 +51,12 @@ qtModule {
   '';
 
   NIX_CFLAGS_COMPILE =
-    # with gcc7 this warning blows the log over Hydra's limit
-    [ "-Wno-expansion-to-defined" ]
+    [
+      # with gcc7 this warning blows the log over Hydra's limit
+      "-Wno-expansion-to-defined"
+      # with gcc8, -Wclass-memaccess became part of -Wall and this too exceeds the logging limit
+      "-Wno-class-memaccess"
+    ]
     # with clang this warning blows the log over Hydra's limit
     ++ optional stdenv.isDarwin "-Wno-inconsistent-missing-override"
     ++ optionals flashplayerFix