about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMario Rodas <marsam@users.noreply.github.com>2024-02-02 18:24:55 -0500
committerGitHub <noreply@github.com>2024-02-02 18:24:55 -0500
commit1df0870bb92e82732529cf98441bb058bb2803e9 (patch)
treecaba23e449c2a8cae92d7f14d6aa1703fcccbba2
parent521d4819bdc9029f3ec641217bb4a71b8a896930 (diff)
parent819f41abefd82ccef60a5b941dfe704871314ce0 (diff)
downloadnixlib-1df0870bb92e82732529cf98441bb058bb2803e9.tar
nixlib-1df0870bb92e82732529cf98441bb058bb2803e9.tar.gz
nixlib-1df0870bb92e82732529cf98441bb058bb2803e9.tar.bz2
nixlib-1df0870bb92e82732529cf98441bb058bb2803e9.tar.lz
nixlib-1df0870bb92e82732529cf98441bb058bb2803e9.tar.xz
nixlib-1df0870bb92e82732529cf98441bb058bb2803e9.tar.zst
nixlib-1df0870bb92e82732529cf98441bb058bb2803e9.zip
Merge pull request #282039 from marsam/gsctl-unpin-go
gsctl: unpin go
-rw-r--r--pkgs/applications/misc/gsctl/default.nix9
-rw-r--r--pkgs/applications/misc/gsctl/go120-compatibility.patch21
-rw-r--r--pkgs/top-level/all-packages.nix4
3 files changed, 31 insertions, 3 deletions
diff --git a/pkgs/applications/misc/gsctl/default.nix b/pkgs/applications/misc/gsctl/default.nix
index bf47ee1899b3..31f8881127d1 100644
--- a/pkgs/applications/misc/gsctl/default.nix
+++ b/pkgs/applications/misc/gsctl/default.nix
@@ -13,6 +13,15 @@ buildGoModule rec {
 
   vendorHash = "sha256-6b4H8YAY8d/qIGnnGPYZoXne1LXHLsc0OEq0lCeqivo=";
 
+  patches = [
+    ./go120-compatibility.patch
+  ];
+
+  postPatch = ''
+    # fails on sandbox
+    rm commands/root_test.go
+  '';
+
   ldflags = [
     "-s" "-w"
     "-X github.com/giantswarm/gsctl/buildinfo.Version=${version}"
diff --git a/pkgs/applications/misc/gsctl/go120-compatibility.patch b/pkgs/applications/misc/gsctl/go120-compatibility.patch
new file mode 100644
index 000000000000..81b393c583a4
--- /dev/null
+++ b/pkgs/applications/misc/gsctl/go120-compatibility.patch
@@ -0,0 +1,21 @@
+--- a/client/clienterror/matcher.go
++++ b/client/clienterror/matcher.go
+@@ -2,6 +2,7 @@ package clienterror
+ 
+ import (
+ 	"crypto/x509"
++	"errors"
+ 	"net/http"
+ 
+ 	"github.com/giantswarm/microerror"
+@@ -101,9 +102,7 @@ func IsServiceUnavailableError(err error) bool {
+ // a x509.UnknownAuthorityError
+ func IsCertificateSignedByUnknownAuthorityError(err error) bool {
+ 	if clientErr, ok := err.(*APIError); ok {
+-		if _, certErrorOK := clientErr.OriginalError.(x509.UnknownAuthorityError); certErrorOK {
+-			return true
+-		}
++		return errors.As(clientErr.OriginalError, &x509.UnknownAuthorityError{})
+ 	}
+ 
+ 	return false
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index eba1fb54804e..44eb231e7e18 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -5608,9 +5608,7 @@ with pkgs;
 
   gscan2pdf = callPackage ../applications/graphics/gscan2pdf { };
 
-  gsctl = callPackage ../applications/misc/gsctl {
-    buildGoModule = buildGo119Module; # go 1.20 build failure
-  };
+  gsctl = callPackage ../applications/misc/gsctl { };
 
   gsocket = callPackage ../tools/networking/gsocket { };