diff options
| author | Jörg Thalheim <joerg@thalheim.io> | 2019-03-08 14:17:28 +0000 |
|---|---|---|
| committer | Jörg Thalheim <joerg@thalheim.io> | 2019-03-20 11:28:00 +0000 |
| commit | 22d083e6598293c7c23a062689bb84e751e35ee7 (patch) | |
| tree | 7b45f6a3000205fdcf17be22bc1f6d217c739191 /.github | |
| parent | eb5afaf06b092469cc3875f48aa20879573f404f (diff) | |
| download | nixlib-22d083e6598293c7c23a062689bb84e751e35ee7.tar nixlib-22d083e6598293c7c23a062689bb84e751e35ee7.tar.gz nixlib-22d083e6598293c7c23a062689bb84e751e35ee7.tar.bz2 nixlib-22d083e6598293c7c23a062689bb84e751e35ee7.tar.lz nixlib-22d083e6598293c7c23a062689bb84e751e35ee7.tar.xz nixlib-22d083e6598293c7c23a062689bb84e751e35ee7.tar.zst nixlib-22d083e6598293c7c23a062689bb84e751e35ee7.zip | |
doc/reviewing-contributions: nix-review instead of nox-review
It is faster, handles more edge cases and allows to test/review the built packages interactively.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 22940f5ea989..7b4ec78e4090 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,11 +11,10 @@ - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) -- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"` +- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after) - [ ] Assured whether relevant documentation is up to date - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). --- - |