about summary refs log tree commit diff
path: root/nixpkgs/pkgs/test/nixpkgs-check-by-name/tests/sorted-order/expected
blob: 8a8104b7372095a3b65303e2f760a09bcdf9180e (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
- Because pkgs/by-name/a/a exists, the attribute `pkgs.a` must be defined like

    a = callPackage ./pkgs/by-name/a/a/package.nix { /* ... */ };

  However, in this PR, the second argument is empty. See the definition in all-packages.nix:2:

    a = self.callPackage ./pkgs/by-name/a/a/package.nix { };

  Such a definition is provided automatically and therefore not necessary. Please remove it.

- Attribute `pkgs.b` is a new top-level package using `pkgs.callPackage ... { /* ... */ }`.
  Please define it in pkgs/by-name/b/b/package.nix instead.
  See `pkgs/by-name/README.md` for more details.
  Since the second `callPackage` argument is `{ }`, no manual `callPackage` in all-packages.nix is needed anymore.

- Because pkgs/by-name/c/c exists, the attribute `pkgs.c` must be defined like

    c = callPackage ./pkgs/by-name/c/c/package.nix { /* ... */ };

  However, in this PR, the second argument is empty. See the definition in all-packages.nix:4:

    c = self.callPackage ./pkgs/by-name/c/c/package.nix { };

  Such a definition is provided automatically and therefore not necessary. Please remove it.

- Attribute `pkgs.d` is a new top-level package using `pkgs.callPackage ... { /* ... */ }`.
  Please define it in pkgs/by-name/d/d/package.nix instead.
  See `pkgs/by-name/README.md` for more details.
  Since the second `callPackage` argument is `{ }`, no manual `callPackage` in all-packages.nix is needed anymore.

This PR introduces additional instances of discouraged patterns as listed above. Merging is discouraged but would not break the base branch.