about summary refs log tree commit diff
diff options
context:
space:
mode:
authorTom Hall <tahall256@protonmail.ch>2018-08-15 17:38:47 +0100
committerThomas.Hall <Thomas.Hall@allen-heath.com>2018-08-24 12:37:57 +0100
commite01c61347e5f5ab030f907a2aaf38d593765b754 (patch)
tree5c4e316fde2cf46ba67c5ab52c1c5569a9b4884f
parentbe34fdfa89f0896e75f236a5e8d0bd11889c20ef (diff)
downloadnixlib-e01c61347e5f5ab030f907a2aaf38d593765b754.tar
nixlib-e01c61347e5f5ab030f907a2aaf38d593765b754.tar.gz
nixlib-e01c61347e5f5ab030f907a2aaf38d593765b754.tar.bz2
nixlib-e01c61347e5f5ab030f907a2aaf38d593765b754.tar.lz
nixlib-e01c61347e5f5ab030f907a2aaf38d593765b754.tar.xz
nixlib-e01c61347e5f5ab030f907a2aaf38d593765b754.tar.zst
nixlib-e01c61347e5f5ab030f907a2aaf38d593765b754.zip
qtwebengine: Use system ffmpeg on aarch64
On aarch64, linking against the vendored ffmpeg fails. Including ffmpeg
as a dependency and passing -system-ffmpeg to qmake fixes this.

Slightly odd conditional in qmakeFlags to avoid altering the list on
non-arm platforms, so that the change doesn't trigger an unneccessary
rebuild.
-rw-r--r--pkgs/development/libraries/qt-5/modules/qtwebengine.nix7
1 files changed, 6 insertions, 1 deletions
diff --git a/pkgs/development/libraries/qt-5/modules/qtwebengine.nix b/pkgs/development/libraries/qt-5/modules/qtwebengine.nix
index dc5f2ae96b3e..757d5b662e28 100644
--- a/pkgs/development/libraries/qt-5/modules/qtwebengine.nix
+++ b/pkgs/development/libraries/qt-5/modules/qtwebengine.nix
@@ -13,6 +13,7 @@
 , systemd
 , enableProprietaryCodecs ? true
 , gn, darwin, openbsm
+, ffmpeg ? null
 , lib, stdenv # lib.optional, needsPax
 }:
 
@@ -117,7 +118,9 @@ EOF
     fi
    '';
 
-  qmakeFlags = optional enableProprietaryCodecs "-- -proprietary-codecs";
+  qmakeFlags = if stdenv.hostPlatform.isAarch32 || stdenv.hostPlatform.isAarch64
+    then [ "--" "-system-ffmpeg" ] ++ optional enableProprietaryCodecs "-proprietary-codecs"
+    else optional enableProprietaryCodecs "-- -proprietary-codecs";
 
   propagatedBuildInputs = [
     # Image formats
@@ -133,6 +136,8 @@ EOF
     harfbuzz icu
 
     libevent
+  ] ++ optionals stdenv.hostPlatform.isArm [
+    ffmpeg
   ] ++ optionals (!stdenv.isDarwin) [
     dbus zlib minizip snappy nss protobuf jsoncpp