diff options
| author | Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> | 2018-05-20 16:46:11 +0300 |
|---|---|---|
| committer | Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> | 2018-05-24 04:58:57 +0300 |
| commit | 7adae10a8632213428d5b6e49d5829974b6a0102 (patch) | |
| tree | a274fdb9719eea48359eba26a98d80fc5ab8235c | |
| parent | 290505bf1bb8e4aa65e07b6eaf1b455439b56e25 (diff) | |
| download | nixlib-7adae10a8632213428d5b6e49d5829974b6a0102.tar nixlib-7adae10a8632213428d5b6e49d5829974b6a0102.tar.gz nixlib-7adae10a8632213428d5b6e49d5829974b6a0102.tar.bz2 nixlib-7adae10a8632213428d5b6e49d5829974b6a0102.tar.lz nixlib-7adae10a8632213428d5b6e49d5829974b6a0102.tar.xz nixlib-7adae10a8632213428d5b6e49d5829974b6a0102.tar.zst nixlib-7adae10a8632213428d5b6e49d5829974b6a0102.zip | |
nixos/programs/shell.nix: Quote variables
In practice $HOME doesn't contain spaces, but let's stick to best shell scripting practices anyway.
| -rw-r--r-- | nixos/modules/programs/shell.nix | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/nixos/modules/programs/shell.nix b/nixos/modules/programs/shell.nix index 3504a8a924b0..d2928a0e6b17 100644 --- a/nixos/modules/programs/shell.nix +++ b/nixos/modules/programs/shell.nix @@ -23,39 +23,39 @@ in environment.shellInit = '' # Set up the per-user profile. - mkdir -m 0755 -p $NIX_USER_PROFILE_DIR - if test "$(stat --printf '%u' $NIX_USER_PROFILE_DIR)" != "$(id -u)"; then + mkdir -m 0755 -p "$NIX_USER_PROFILE_DIR" + if test "$(stat --printf '%u' "$NIX_USER_PROFILE_DIR")" != "$(id -u)"; then echo "WARNING: bad ownership on $NIX_USER_PROFILE_DIR" >&2 fi - if test -w $HOME; then - if ! test -L $HOME/.nix-profile; then + if test -w "$HOME"; then + if ! test -L "$HOME/.nix-profile"; then if test "$USER" != root; then - ln -s $NIX_USER_PROFILE_DIR/profile $HOME/.nix-profile + ln -s "$NIX_USER_PROFILE_DIR/profile" "$HOME/.nix-profile" else # Root installs in the system-wide profile by default. - ln -s /nix/var/nix/profiles/default $HOME/.nix-profile + ln -s /nix/var/nix/profiles/default "$HOME/.nix-profile" fi fi # Subscribe the root user to the NixOS channel by default. - if [ "$USER" = root -a ! -e $HOME/.nix-channels ]; then - echo "${config.system.nixos.defaultChannel} nixos" > $HOME/.nix-channels + if [ "$USER" = root -a ! -e "$HOME/.nix-channels" ]; then + echo "${config.system.nixos.defaultChannel} nixos" > "$HOME/.nix-channels" fi # Create the per-user garbage collector roots directory. - NIX_USER_GCROOTS_DIR=/nix/var/nix/gcroots/per-user/$USER - mkdir -m 0755 -p $NIX_USER_GCROOTS_DIR - if test "$(stat --printf '%u' $NIX_USER_GCROOTS_DIR)" != "$(id -u)"; then + NIX_USER_GCROOTS_DIR="/nix/var/nix/gcroots/per-user/$USER" + mkdir -m 0755 -p "$NIX_USER_GCROOTS_DIR" + if test "$(stat --printf '%u' "$NIX_USER_GCROOTS_DIR")" != "$(id -u)"; then echo "WARNING: bad ownership on $NIX_USER_GCROOTS_DIR" >&2 fi # Set up a default Nix expression from which to install stuff. - if [ ! -e $HOME/.nix-defexpr -o -L $HOME/.nix-defexpr ]; then - rm -f $HOME/.nix-defexpr - mkdir -p $HOME/.nix-defexpr + if [ ! -e "$HOME/.nix-defexpr" -o -L "$HOME/.nix-defexpr" ]; then + rm -f "$HOME/.nix-defexpr" + mkdir -p "$HOME/.nix-defexpr" if [ "$USER" != root ]; then - ln -s /nix/var/nix/profiles/per-user/root/channels $HOME/.nix-defexpr/channels_root + ln -s /nix/var/nix/profiles/per-user/root/channels "$HOME/.nix-defexpr/channels_root" fi fi fi |