From c57ae8228761cc3ae845e6841ff7beae4a3c73a0 Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Wed, 16 Feb 2022 13:47:27 +0000 Subject: Fix clippy warnings --- src/github.rs | 2 +- src/main.rs | 2 +- src/tree.rs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/github.rs b/src/github.rs index 1128f95..e5be0d3 100644 --- a/src/github.rs +++ b/src/github.rs @@ -117,7 +117,7 @@ impl<'a> GitHub<'a> { fn authorization_header(&self) -> Result { let mut value = b"bearer ".to_vec(); value.extend_from_slice(self.token.as_bytes()); - Ok(HeaderValue::from_bytes(value)?) + HeaderValue::from_bytes(value) } pub async fn pr_info_for_nixpkgs_pr(&self, pr: i64) -> Result { diff --git a/src/main.rs b/src/main.rs index 0b70a15..6073b9a 100644 --- a/src/main.rs +++ b/src/main.rs @@ -162,7 +162,7 @@ async fn main() { E: std::error::Error, { match result { - Ok(v) => return v, + Ok(v) => v, Err(e) => { eprintln!("pr-tracker: {}: {}", message.as_ref(), e); exit(code); diff --git a/src/tree.rs b/src/tree.rs index fb56c99..91dc05d 100644 --- a/src/tree.rs +++ b/src/tree.rs @@ -30,7 +30,7 @@ impl Tree { .map(|b| Self::generate(b.to_string(), found_branches)) .collect(); - let link = branch_hydra_link(&branch).map(|l| l.to_string()); + let link = branch_hydra_link(&branch); Tree { accepted: None, @@ -70,7 +70,7 @@ impl Tree { let mut containing_commits = BTreeSet::new(); if let Err(e) = nixpkgs - .branches_containing_commit(&merge_commit, &mut containing_commits) + .branches_containing_commit(merge_commit, &mut containing_commits) .await { eprintln!("pr-tracker: branches_containing_commit: {}", e); -- cgit 1.4.1