about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAlyssa Ross <hi@alyssa.is>2022-02-16 13:47:27 +0000
committerAlyssa Ross <hi@alyssa.is>2022-02-16 17:17:30 +0000
commitc57ae8228761cc3ae845e6841ff7beae4a3c73a0 (patch)
treee9a10f0f19198cbf47f14b6e644c09f8c81cc237
parent7f87e6d8eb219f0bcf9266ea2fb5c4062a57c0c2 (diff)
downloadpr-tracker-c57ae8228761cc3ae845e6841ff7beae4a3c73a0.tar
pr-tracker-c57ae8228761cc3ae845e6841ff7beae4a3c73a0.tar.gz
pr-tracker-c57ae8228761cc3ae845e6841ff7beae4a3c73a0.tar.bz2
pr-tracker-c57ae8228761cc3ae845e6841ff7beae4a3c73a0.tar.lz
pr-tracker-c57ae8228761cc3ae845e6841ff7beae4a3c73a0.tar.xz
pr-tracker-c57ae8228761cc3ae845e6841ff7beae4a3c73a0.tar.zst
pr-tracker-c57ae8228761cc3ae845e6841ff7beae4a3c73a0.zip
Fix clippy warnings
-rw-r--r--src/github.rs2
-rw-r--r--src/main.rs2
-rw-r--r--src/tree.rs4
3 files changed, 4 insertions, 4 deletions
diff --git a/src/github.rs b/src/github.rs
index 1128f95..e5be0d3 100644
--- a/src/github.rs
+++ b/src/github.rs
@@ -117,7 +117,7 @@ impl<'a> GitHub<'a> {
     fn authorization_header(&self) -> Result<HeaderValue, surf::Error> {
         let mut value = b"bearer ".to_vec();
         value.extend_from_slice(self.token.as_bytes());
-        Ok(HeaderValue::from_bytes(value)?)
+        HeaderValue::from_bytes(value)
     }
 
     pub async fn pr_info_for_nixpkgs_pr(&self, pr: i64) -> Result<PrInfo, Error> {
diff --git a/src/main.rs b/src/main.rs
index 0b70a15..6073b9a 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -162,7 +162,7 @@ async fn main() {
         E: std::error::Error,
     {
         match result {
-            Ok(v) => return v,
+            Ok(v) => v,
             Err(e) => {
                 eprintln!("pr-tracker: {}: {}", message.as_ref(), e);
                 exit(code);
diff --git a/src/tree.rs b/src/tree.rs
index fb56c99..91dc05d 100644
--- a/src/tree.rs
+++ b/src/tree.rs
@@ -30,7 +30,7 @@ impl Tree {
             .map(|b| Self::generate(b.to_string(), found_branches))
             .collect();
 
-        let link = branch_hydra_link(&branch).map(|l| l.to_string());
+        let link = branch_hydra_link(&branch);
 
         Tree {
             accepted: None,
@@ -70,7 +70,7 @@ impl Tree {
                 let mut containing_commits = BTreeSet::new();
 
                 if let Err(e) = nixpkgs
-                    .branches_containing_commit(&merge_commit, &mut containing_commits)
+                    .branches_containing_commit(merge_commit, &mut containing_commits)
                     .await
                 {
                     eprintln!("pr-tracker: branches_containing_commit: {}", e);