From 0a541aa38c47108bffb1c78cef0e09e125cc6023 Mon Sep 17 00:00:00 2001 From: Mitsuhiro Nakamura Date: Fri, 3 Aug 2018 01:06:36 +0900 Subject: rPackages.buildRPackage: fix error if requireX is missing --- pkgs/development/r-modules/generic-builder.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'pkgs') diff --git a/pkgs/development/r-modules/generic-builder.nix b/pkgs/development/r-modules/generic-builder.nix index 0d731de33f84..76bf29abc17c 100644 --- a/pkgs/development/r-modules/generic-builder.nix +++ b/pkgs/development/r-modules/generic-builder.nix @@ -1,10 +1,10 @@ { stdenv, R, libcxx, xvfb_run, utillinux, Cocoa, Foundation, gettext, gfortran }: -{ name, buildInputs ? [], ... } @ attrs: +{ name, buildInputs ? [], requireX ? false, ... } @ attrs: stdenv.mkDerivation ({ buildInputs = buildInputs ++ [R gettext] ++ - stdenv.lib.optionals attrs.requireX [utillinux xvfb_run] ++ + stdenv.lib.optionals requireX [utillinux xvfb_run] ++ stdenv.lib.optionals stdenv.isDarwin [Cocoa Foundation gfortran]; NIX_CFLAGS_COMPILE = @@ -26,7 +26,7 @@ stdenv.mkDerivation ({ else [ "--no-test-load" ]; - rCommand = if attrs.requireX or false then + rCommand = if requireX then # Unfortunately, xvfb-run has a race condition even with -a option, so that # we acquire a lock explicitly. "flock ${xvfb_run} xvfb-run -a -e xvfb-error R" -- cgit 1.4.1