From ce0954020c71007b7a9ec2822949d31f18aea170 Mon Sep 17 00:00:00 2001 From: aszlig Date: Tue, 12 Apr 2016 05:13:04 +0200 Subject: nixos/taskserver: Set allowedTCPPorts accordingly As suggested by @matthiasbeyer: "We might add a short note that this port has to be opened in the firewall, or is this done by the service automatically?" This commit now adds the listenPort to networking.firewall.allowedTCPPorts as soon as the listenHost is not "localhost". In addition to that, this is now also documented in the listenHost option declaration and I have removed disabling of the firewall from the VM test. Signed-off-by: aszlig --- nixos/tests/taskserver.nix | 2 -- 1 file changed, 2 deletions(-) (limited to 'nixos/tests') diff --git a/nixos/tests/taskserver.nix b/nixos/tests/taskserver.nix index 79a7703f037e..0521f97431b3 100644 --- a/nixos/tests/taskserver.nix +++ b/nixos/tests/taskserver.nix @@ -3,7 +3,6 @@ import ./make-test.nix { nodes = rec { server = { - networking.firewall.enable = false; services.taskserver.enable = true; services.taskserver.listenHost = "::"; services.taskserver.fqdn = "server"; @@ -14,7 +13,6 @@ import ./make-test.nix { }; client1 = { pkgs, ... }: { - networking.firewall.enable = false; environment.systemPackages = [ pkgs.taskwarrior pkgs.gnutls ]; users.users.alice.isNormalUser = true; users.users.bob.isNormalUser = true; -- cgit 1.4.1