From 89b5dddf990fd7fe99528a972ff037002e8e3046 Mon Sep 17 00:00:00 2001 From: Sandro Jäckel Date: Sat, 10 Dec 2022 03:40:39 +0100 Subject: nixos/avahi: revert closing firewall port by default --- nixos/doc/manual/from_md/release-notes/rl-2305.section.xml | 10 ---------- nixos/doc/manual/release-notes/rl-2305.section.md | 2 -- nixos/modules/services/networking/avahi-daemon.nix | 5 +++-- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml b/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml index cc330e2f8870..944ea12f7df6 100644 --- a/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml +++ b/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml @@ -87,16 +87,6 @@ true, or configure your firewall. - - - The - services.avahi.openFirewall - module option default value has been changed from - true to false. You will - need to explicitely set this option to - true, or configure your firewall. - - The diff --git a/nixos/doc/manual/release-notes/rl-2305.section.md b/nixos/doc/manual/release-notes/rl-2305.section.md index 886db43c68eb..2dd632fa7b92 100644 --- a/nixos/doc/manual/release-notes/rl-2305.section.md +++ b/nixos/doc/manual/release-notes/rl-2305.section.md @@ -31,8 +31,6 @@ In addition to numerous new and upgraded packages, this release has the followin - The [services.snapserver.openFirewall](#opt-services.snapserver.openFirewall) module option default value has been changed from `true` to `false`. You will need to explicitely set this option to `true`, or configure your firewall. -- The [services.avahi.openFirewall](#opt-services.avahi.openFirewall) module option default value has been changed from `true` to `false`. You will need to explicitely set this option to `true`, or configure your firewall. - - The [services.tmate-ssh-server.openFirewall](#opt-services.tmate-ssh-server.openFirewall) module option default value has been changed from `true` to `false`. You will need to explicitely set this option to `true`, or configure your firewall. - The [services.unifi-video.openFirewall](#opt-services.unifi-video.openFirewall) module option default value has been changed from `true` to `false`. You will need to explicitely set this option to `true`, or configure your firewall. diff --git a/nixos/modules/services/networking/avahi-daemon.nix b/nixos/modules/services/networking/avahi-daemon.nix index 0875d8a85140..3933ed5a2315 100644 --- a/nixos/modules/services/networking/avahi-daemon.nix +++ b/nixos/modules/services/networking/avahi-daemon.nix @@ -103,16 +103,17 @@ in openFirewall = mkOption { type = types.bool; - default = false; + default = true; description = lib.mdDoc '' Whether to open the firewall for UDP port 5353. + Disabling this setting also disables discovering of network devices. ''; }; allowPointToPoint = mkOption { type = types.bool; default = false; - description= lib.mdDoc '' + description = lib.mdDoc '' Whether to use POINTTOPOINT interfaces. Might make mDNS unreliable due to usually large latencies with such links and opens a potential security hole by allowing mDNS access from Internet connections. -- cgit 1.4.1 From 3836639c13c483ec85fedd292d5363401be7266f Mon Sep 17 00:00:00 2001 From: Sandro Jäckel Date: Sat, 10 Dec 2022 03:41:07 +0100 Subject: avahi: remove not required ? null from inputs --- pkgs/development/libraries/avahi/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/libraries/avahi/default.nix b/pkgs/development/libraries/avahi/default.nix index fe9ce9a42dcb..d57b6a75cbaa 100644 --- a/pkgs/development/libraries/avahi/default.nix +++ b/pkgs/development/libraries/avahi/default.nix @@ -13,8 +13,8 @@ , libevent , nixosTests , gtk3Support ? false -, gtk3 ? null -, qt5 ? null +, gtk3 +, qt5 , qt5Support ? false , withLibdnssdCompat ? false , python ? null -- cgit 1.4.1