| Commit message (Collapse) | Author | Age |
... | |
|\
| |
| | |
CODEOWNERS file for review requests
|
| |
| |
| |
| |
| |
| |
| | |
Some time ago GitHub introduced the CODEOWNERS file. The file is similar
to the MAINTAINERS file that was proposed in
https://github.com/NixOS/nixpkgs/issues/13602. Code owners will
automatically receive a review request.
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
| |
Suggest prefixing commit messages that touches NixOS code with
"nixos/<module>" instead of the current "<name> service" prefix.
"<name> service" is limiting in that NixOS code is more than the
services. It is also easier to spot NixOS changes with explicit
"nixos/..." prefix.
|
|
|
|
|
|
|
|
|
|
|
| |
On several occasions I've seen people bumping packages which have NixOS
tests but without actually running them.
While this probably won't prevent such occasions entirely, at least it
serves as an additional checklist item so contributors don't forget
about these tests.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
|
| |
|
|
|
|
|
| |
Add a brief request for expressing the motivation for a change. Change the example commit messages to match.
Resolves #19126.
|
|
|
|
| |
Fixes #20594.
|
|
|
| |
Follow the rebranding of OS X into macOS
|
|\
| |
| | |
[WIP] nixos-doc: add reviewing contributions chapter
|
| | |
|
| | |
|
|/
|
|
| |
The current link returns a 404 error
|
|
|
| |
See https://github.com/NixOS/nix/commit/b39622a487e2978bd32c9faf2f651aec1f9815c1
|
|
|
|
|
| |
The old one works on all nix(os) versions, whereas the new one doesn't
work e.g. on default 16.03 setting. Discussed on #15112.
|
|
|
| |
I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change.
|
|
|
|
|
|
|
| |
It's been reported that when running through nix daemon,
sandboxing can't be turned on by passing `--option` (silently ignored),
so let's not suggest that way.
https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
|
|
|
|
|
| |
On Nix side this was done months ago:
https://github.com/NixOS/nix/pull/682
|
| |
|
|
|
|
|
| |
* Highlight the top mistakes directly in CONTRIBUTING.md
* Remove unecessary cruft from the PR template
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
CONTRIBUTING.md: Fix link to COPYING
|
| | |
|
|/
|
|
|
|
| |
The goal is to get all the necessary information from the reporter upfront.
Too many times the issues submits and we need to do a round of asking before
we can get close to a solution.
|
|\
| |
| | |
PULL_REQUEST_TEMPLATE: init
|
| |
|
|
See https://github.com/blog/2111-issue-and-pull-request-templates.
|