summary refs log tree commit diff
path: root/pkgs
diff options
context:
space:
mode:
authoraszlig <aszlig@redmoonstudios.org>2014-12-30 23:06:28 +0100
committeraszlig <aszlig@redmoonstudios.org>2014-12-30 23:06:28 +0100
commitf2364772b8c1c77c6f446909d7db5f236efdd978 (patch)
tree3ec3a815d91d46672e8b8ec82aee6ef6fe4a20ff /pkgs
parent2acc258dff1a37974edd6475851e218bb09e281a (diff)
downloadnixlib-f2364772b8c1c77c6f446909d7db5f236efdd978.tar
nixlib-f2364772b8c1c77c6f446909d7db5f236efdd978.tar.gz
nixlib-f2364772b8c1c77c6f446909d7db5f236efdd978.tar.bz2
nixlib-f2364772b8c1c77c6f446909d7db5f236efdd978.tar.lz
nixlib-f2364772b8c1c77c6f446909d7db5f236efdd978.tar.xz
nixlib-f2364772b8c1c77c6f446909d7db5f236efdd978.tar.zst
nixlib-f2364772b8c1c77c6f446909d7db5f236efdd978.zip
beets: Use audiotools backend for replaygain.
Using commands such as mp3gain and aacgain is only the default for
backwards-compatible reasons. However, on Nix(OS), we would have to
either patch those tools into beets or rely on an impurity, so let's
depend on audiotools and also default to that backend.

Of course, there is also a GStreamer backend, but it comes with a hell
of additional dependencies (which not only cover audio files), which is
why I decided against defaulting to GStreamer and package audiotools
instead (in eecd932).

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Diffstat (limited to 'pkgs')
-rw-r--r--pkgs/tools/audio/beets/default.nix5
-rw-r--r--pkgs/tools/audio/beets/replaygain-default-audiotools.patch17
2 files changed, 21 insertions, 1 deletions
diff --git a/pkgs/tools/audio/beets/default.nix b/pkgs/tools/audio/beets/default.nix
index d0a3a922f2bf..a052a994afda 100644
--- a/pkgs/tools/audio/beets/default.nix
+++ b/pkgs/tools/audio/beets/default.nix
@@ -99,7 +99,10 @@ in buildPythonPackage rec {
     responses
   ];
 
-  patches = [ ./mediafile-codec-fix.patch ];
+  patches = [
+    ./mediafile-codec-fix.patch
+    ./replaygain-default-audiotools.patch
+  ];
 
   postPatch = ''
     sed -i -e '/assertIn.*item.*path/d' test/test_info.py
diff --git a/pkgs/tools/audio/beets/replaygain-default-audiotools.patch b/pkgs/tools/audio/beets/replaygain-default-audiotools.patch
new file mode 100644
index 000000000000..d852ea6fecaa
--- /dev/null
+++ b/pkgs/tools/audio/beets/replaygain-default-audiotools.patch
@@ -0,0 +1,17 @@
+diff --git a/beetsplug/replaygain.py b/beetsplug/replaygain.py
+index 40b3a3a..9b54a5a 100644
+--- a/beetsplug/replaygain.py
++++ b/beetsplug/replaygain.py
+@@ -627,11 +627,10 @@ class ReplayGainPlugin(BeetsPlugin):
+         super(ReplayGainPlugin, self).__init__()
+         self.import_stages = [self.imported]
+ 
+-        # default backend is 'command' for backward-compatibility.
+         self.config.add({
+             'overwrite': False,
+             'auto': True,
+-            'backend': u'command',
++            'backend': u'audiotools',
+             'targetlevel': 89,
+         })
+