diff options
author | Luca Bruno <lethalman88@gmail.com> | 2015-08-26 12:10:08 +0200 |
---|---|---|
committer | Luca Bruno <lethalman88@gmail.com> | 2015-08-26 12:11:27 +0200 |
commit | 75ed15e174996139e439fdca407f03fadfe929da (patch) | |
tree | 77ba00f0eb25d10243feb058532a2b5a10cd43e0 /pkgs | |
parent | 9458bde4c157bd83857e92acacff9365548bd79d (diff) | |
download | nixlib-75ed15e174996139e439fdca407f03fadfe929da.tar nixlib-75ed15e174996139e439fdca407f03fadfe929da.tar.gz nixlib-75ed15e174996139e439fdca407f03fadfe929da.tar.bz2 nixlib-75ed15e174996139e439fdca407f03fadfe929da.tar.lz nixlib-75ed15e174996139e439fdca407f03fadfe929da.tar.xz nixlib-75ed15e174996139e439fdca407f03fadfe929da.tar.zst nixlib-75ed15e174996139e439fdca407f03fadfe929da.zip |
goPackages: disable parallel builds
It breaks cascadia tests. If a process terminates before wait, the PID is non-existant and wait fails. Using & and wait in bash is just broken and shouldn't be used. We shall probably use GNU parallel for this job. cc @wkennington
Diffstat (limited to 'pkgs')
-rw-r--r-- | pkgs/development/go-modules/generic/default.nix | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/pkgs/development/go-modules/generic/default.nix b/pkgs/development/go-modules/generic/default.nix index fafefd325dfd..7ab3c892f569 100644 --- a/pkgs/development/go-modules/generic/default.nix +++ b/pkgs/development/go-modules/generic/default.nix @@ -80,8 +80,8 @@ go.stdenv.mkDerivation ( PIDS=() if [ -n "$subPackages" ] ; then for p in $subPackages ; do - go install $buildFlags "''${buildFlagsArray[@]}" -p $NIX_BUILD_CORES -v $goPackagePath/$p & - PIDS+=("$!") + go install $buildFlags "''${buildFlagsArray[@]}" -p $NIX_BUILD_CORES -v $goPackagePath/$p + #PIDS+=("$!") done else pushd go/src @@ -99,8 +99,8 @@ go.stdenv.mkDerivation ( if [ -n "$OUT" ]; then echo "$OUT" >&2 fi - } & - PIDS+=("$!") + } + #PIDS+=("$!") done < <(find $goPackagePath -type f -name \*.go -exec dirname {} \; | sort | uniq) popd fi @@ -119,16 +119,16 @@ go.stdenv.mkDerivation ( PIDS=() if [ -n "$subPackages" ] ; then for p in $subPackages ; do - go test -p $NIX_BUILD_CORES -v $goPackagePath/$p & + go test -p $NIX_BUILD_CORES -v $goPackagePath/$p done - PIDS+=("$!") + #PIDS+=("$!") else pushd go/src while read d; do go test -p $NIX_BUILD_CORES -v $d done < <(find $goPackagePath -type f -name \*_test.go -exec dirname {} \; | sort | uniq) popd - PIDS+=("$!") + #PIDS+=("$!") fi # Exit on error from the parallel process |