summary refs log tree commit diff
path: root/pkgs/top-level
diff options
context:
space:
mode:
authorMaximilian Bosch <maximilian@mbosch.me>2018-06-26 17:34:34 +0200
committerMaximilian Bosch <maximilian@mbosch.me>2018-06-26 17:34:34 +0200
commit8d6502f8ca9bd59931de4d0f7d74c805b34f7d14 (patch)
tree709d69603049c1477ab0ca55158871e2a960a7f3 /pkgs/top-level
parent68bf1063f02d7c1e6b2caa7cf725b884f1865296 (diff)
downloadnixlib-8d6502f8ca9bd59931de4d0f7d74c805b34f7d14.tar
nixlib-8d6502f8ca9bd59931de4d0f7d74c805b34f7d14.tar.gz
nixlib-8d6502f8ca9bd59931de4d0f7d74c805b34f7d14.tar.bz2
nixlib-8d6502f8ca9bd59931de4d0f7d74c805b34f7d14.tar.lz
nixlib-8d6502f8ca9bd59931de4d0f7d74c805b34f7d14.tar.xz
nixlib-8d6502f8ca9bd59931de4d0f7d74c805b34f7d14.tar.zst
nixlib-8d6502f8ca9bd59931de4d0f7d74c805b34f7d14.zip
phonon-backend-vlc: use qt5 by default
`minitube` is currently broken transitively due to the broken
`phonon-backend-qt4`: https://hydra.nixos.org/build/76523277

Although QT4 is fairly old, this package is still built with `qt4` ATM,
however QT5 is available as well. After this change, QT5 will be built
by default and in case anybody requires legacy QT4 it has to be enabled
explicitly like this:

```
with import <nixpkgs> { };
phonon-backend-vlc.override { withQt4 = true; }
```

Now the QT5-only build can be used (which fixes `minitube`) and there
are no confusions anymore with the build dependencies. Previously
`phonon-backend-vlc` and `libsForQt5.phonon-backend-vlc` used `qt4` by
default which was likely responsible for broken `minitube`.
Diffstat (limited to 'pkgs/top-level')
-rw-r--r--pkgs/top-level/all-packages.nix5
1 files changed, 4 insertions, 1 deletions
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 50736caab838..d4a437ebabe7 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -11192,7 +11192,10 @@ with pkgs;
 
   phonon-backend-gstreamer = callPackage ../development/libraries/phonon/backends/gstreamer.nix {};
 
-  phonon-backend-vlc = callPackage ../development/libraries/phonon/backends/vlc.nix {};
+  # TODO(@Ma27) get rid of that as soon as QT4 can be dropped
+  phonon-backend-vlc = callPackage ../development/libraries/phonon/backends/vlc.nix {
+    withQt4 = true;
+  };
 
   inherit (callPackage ../development/libraries/physfs { })
     physfs_2