summary refs log tree commit diff
path: root/pkgs/tools/misc
diff options
context:
space:
mode:
authorTuomas Tynkkynen <tuomas@tuxera.com>2018-07-19 02:31:23 +0300
committerTuomas Tynkkynen <tuomas@tuxera.com>2018-07-19 02:31:23 +0300
commita595896c5686881a73c6819fbc9b0d1967cfea60 (patch)
tree012072ac3c7b653a6018a9f14516c55556234661 /pkgs/tools/misc
parent0a46f8c19897846db3d9fd2aa858b212a0f2a59d (diff)
downloadnixlib-a595896c5686881a73c6819fbc9b0d1967cfea60.tar
nixlib-a595896c5686881a73c6819fbc9b0d1967cfea60.tar.gz
nixlib-a595896c5686881a73c6819fbc9b0d1967cfea60.tar.bz2
nixlib-a595896c5686881a73c6819fbc9b0d1967cfea60.tar.lz
nixlib-a595896c5686881a73c6819fbc9b0d1967cfea60.tar.xz
nixlib-a595896c5686881a73c6819fbc9b0d1967cfea60.tar.zst
nixlib-a595896c5686881a73c6819fbc9b0d1967cfea60.zip
diffoscope: Document the script to locate missing optional dependencies
And give it it a bit more descriptive name of list-missing-tools.sh.
Diffstat (limited to 'pkgs/tools/misc')
-rw-r--r--pkgs/tools/misc/diffoscope/default.nix4
-rwxr-xr-xpkgs/tools/misc/diffoscope/list-missing-tools.sh (renamed from pkgs/tools/misc/diffoscope/list-tools.sh)3
2 files changed, 7 insertions, 0 deletions
diff --git a/pkgs/tools/misc/diffoscope/default.nix b/pkgs/tools/misc/diffoscope/default.nix
index 73b7f2272cdd..e55d5c89b5b1 100644
--- a/pkgs/tools/misc/diffoscope/default.nix
+++ b/pkgs/tools/misc/diffoscope/default.nix
@@ -6,6 +6,7 @@
 , enableBloat ? false
 }:
 
+# Note: when upgrading this package, please run the list-missing-tools.sh script as described below!
 python3Packages.buildPythonApplication rec {
   name = "diffoscope-${version}";
   version = "99";
@@ -30,6 +31,9 @@ python3Packages.buildPythonApplication rec {
 
   nativeBuildInputs = [ docutils help2man ];
 
+  # Most of the non-Python dependencies here are optional command-line tools for various file-format parsers.
+  # To help figuring out what's missing from the list, run: ./pkgs/tools/misc/diffoscope/list-missing-tools.sh
+  #
   # Still missing these tools: abootimg docx2txt dumpxsb enjarify js-beautify lipo oggDump otool procyon-decompiler Rscript
   # Also these libraries: python3-guestfs
   pythonPath = with python3Packages; [ debian libarchive-c python_magic tlsh rpm ] ++ [
diff --git a/pkgs/tools/misc/diffoscope/list-tools.sh b/pkgs/tools/misc/diffoscope/list-missing-tools.sh
index 9af7f0e38899..5f4d118cfed7 100755
--- a/pkgs/tools/misc/diffoscope/list-tools.sh
+++ b/pkgs/tools/misc/diffoscope/list-missing-tools.sh
@@ -1,5 +1,8 @@
 #!/usr/bin/env bash
 
+# This script lists all the optional command-line tools that diffoscope can use
+# (i.e. `diffoscope --list-tools`) but are missing from the Nix expression.
+
 diffoscope=$(nix-build --no-out-link -E 'with import ./. {}; diffoscope.override { enableBloat = true; }')/bin/diffoscope
 
 required=$($diffoscope --list-tools | \