diff options
author | 8573 <8573@users.noreply.github.com> | 2016-08-17 11:34:26 +0000 |
---|---|---|
committer | Rok Garbas <rok@garbas.si> | 2016-08-17 13:34:26 +0200 |
commit | 34435a9502cb99e565c8d39e4afae9e1f62a365b (patch) | |
tree | 70077189c3f7c3e451565ba364701fc68b5801b8 /pkgs/servers/nosql | |
parent | d965dfc00d89c4a50393f5834bab2e29b2e401ae (diff) | |
download | nixlib-34435a9502cb99e565c8d39e4afae9e1f62a365b.tar nixlib-34435a9502cb99e565c8d39e4afae9e1f62a365b.tar.gz nixlib-34435a9502cb99e565c8d39e4afae9e1f62a365b.tar.bz2 nixlib-34435a9502cb99e565c8d39e4afae9e1f62a365b.tar.lz nixlib-34435a9502cb99e565c8d39e4afae9e1f62a365b.tar.xz nixlib-34435a9502cb99e565c8d39e4afae9e1f62a365b.tar.zst nixlib-34435a9502cb99e565c8d39e4afae9e1f62a365b.zip |
redshift: Fix default value of $DISPLAY (#17746)
Before commit 54fa0cfe4eef7e54e23380704af70ee7b65473ce, the `redshift` service was run with the environment variable `DISPLAY` set to `:0`. Commit 54fa0cfe4eef7e54e23380704af70ee7b65473ce changed this to instead use the value of the `services.xserver.display` configuration option in the value of the `DISPLAY` variable. In so doing, no default value was provided for the case where `services.xserver.display` is `null`. While the default value of `services.xserver.display` is `0`, use of which by the `redshift` module would result in `DISPLAY` again being set to `:0`, `services.xserver.display` may also be `null`, to which value it is set by, e.g., the `lightdm` module. In the case that `services.xserver.display` is `null`, with the change made in commit 54fa0cfe4eef7e54e23380704af70ee7b65473ce, the `DISPLAY` variable in the environment of the `redshift` service would be set to `:` (a single colon), which, according to my personal experience, would result in — - the `redshift` service failing to start; and - systemd repeatedly attempting to restart the `redshift` service, looping indefinitely, while the hapless `redshift` spews error messages into the journal. It can be observed that the malformed value of `DISPLAY` is likely at fault for this issue by executing the following commands in an ordinary shell, with a suitable `redshift` executable, and the X11 display not already tinted: - `redshift -O 2500` — This command should reduce the color temperature of the display (making it more reddish). - `DISPLAY=':' redshift -O 6500` — This command should raise the color temperature back up, were it not for the `DISPLAY` environment variable being set to `:` for it, which should cause it to, instead, fail with several error messages. This commit attempts to fix this issue by having the `DISPLAY` environment variable for the `redshift` service default to its old value of `:0` in the case that `services.xserver.display` is `null`. I have tested this solution on NixOS, albeit without the benefit of a system with multiple displays.
Diffstat (limited to 'pkgs/servers/nosql')
0 files changed, 0 insertions, 0 deletions