diff options
| author | Matthew Justin Bauer <mjbauer95@gmail.com> | 2018-06-12 22:54:10 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-06-12 22:54:10 -0400 |
| commit | 412e823f295830c3ab54d6a35d5a603bd8ec58ea (patch) | |
| tree | 551b2a7bdc1b9635d24fd4cbbbc55b4f3a114408 /pkgs/development/tools/misc | |
| parent | 7f3de607584bd21b5b2512e2551a9f13289b2d7a (diff) | |
| download | nixlib-412e823f295830c3ab54d6a35d5a603bd8ec58ea.tar nixlib-412e823f295830c3ab54d6a35d5a603bd8ec58ea.tar.gz nixlib-412e823f295830c3ab54d6a35d5a603bd8ec58ea.tar.bz2 nixlib-412e823f295830c3ab54d6a35d5a603bd8ec58ea.tar.lz nixlib-412e823f295830c3ab54d6a35d5a603bd8ec58ea.tar.xz nixlib-412e823f295830c3ab54d6a35d5a603bd8ec58ea.tar.zst nixlib-412e823f295830c3ab54d6a35d5a603bd8ec58ea.zip | |
binutils: disable format hardening
This fails for me:
> compressed_output.cc:320:20: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
> gold_warning(_("not compressing section data: zlib error"));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./system.h:40:20: note: expanded from macro '_'
> # define _(String) gettext (String)
> ^~~~~~~~~~~~~~~~
> compressed_output.cc:320:20: note: treat the string as an argument to avoid this
> gold_warning(_("not compressing section data: zlib error"));
> ^
> "%s",
> ./system.h:40:20: note: expanded from macro '_'
> # define _(String) gettext (String)
^
Disabling format hardening should hopefully be harmless here. If it's a problem we can also make it conditional.
/cc @Ericson2314Diffstat (limited to 'pkgs/development/tools/misc')
| -rw-r--r-- | pkgs/development/tools/misc/binutils/default.nix | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/pkgs/development/tools/misc/binutils/default.nix b/pkgs/development/tools/misc/binutils/default.nix index de316d0e5e7f..0b71c6719dc4 100644 --- a/pkgs/development/tools/misc/binutils/default.nix +++ b/pkgs/development/tools/misc/binutils/default.nix @@ -103,6 +103,8 @@ stdenv.mkDerivation rec { then "-Wno-string-plus-int -Wno-deprecated-declarations" else "-static-libgcc"; + hardeningDisable = [ "format" ]; + # TODO(@Ericson2314): Always pass "--target" and always targetPrefix. configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target"; |