pythonPackages: remove `name` attribute`

The `buildPython*` function computes name from `pname` and `version`.
This change removes `name` attribute from all expressions in
`pkgs/development/python-modules`.

While at it, some other minor changes were made as well, such as
replacing `fetchurl` calls with `fetchPypi`.

1 files changed, 5 insertions, 5 deletions

diff --git a/pkgs/development/python-modules/dkimpy/default.nix b/pkgs/development/python-modules/dkimpy/default.nix
index 177e697aab9f..01224515d926 100644
--- a/pkgs/development/python-modules/dkimpy/default.nix
+++ b/pkgs/development/python-modules/dkimpy/default.nix
@@ -1,19 +1,19 @@
 { stdenv, fetchurl, openssl, makeWrapper, buildPythonApplication
 , pytest, dnspython }:
 
-buildPythonApplication rec {
-  name = "${pname}-${version}";
-  pname = "dkimpy";
+let
   majorversion = "0.6";
   minorversion = "2";
+in buildPythonApplication rec {
+  pname = "dkimpy";
   version = "${majorversion}.${minorversion}";
 
   src = fetchurl {
-    url = "https://launchpad.net/${pname}/${majorversion}/${majorversion}.${minorversion}/+download/${name}.tar.gz";
+    url = "https://launchpad.net/${pname}/${majorversion}/${majorversion}.${minorversion}/+download/${pname}-${version}.tar.gz";
     sha256 = "1hagz8qk0v4ijfbcdq4z28bpgr2mkpr498z76i1vam2d50chmakl";
   };
 
-  buildInputs = [ pytest ];
+  checkInputs = [ pytest ];
   propagatedBuildInputs =  [ openssl dnspython ];
 
   patchPhase = ''