summary refs log tree commit diff
path: root/pkgs/development/compilers
diff options
context:
space:
mode:
authorJohn Ericson <John.Ericson@Obsidian.Systems>2018-04-03 12:50:25 -0400
committerJohn Ericson <John.Ericson@Obsidian.Systems>2018-04-03 13:34:52 -0400
commitadaa110a72175c4f841722ab7d2bee7564656e91 (patch)
treed21d57153c20ed22b723191670b0b3252f8e93d9 /pkgs/development/compilers
parent97145012565cd4ef9c8c16a426c3ea505ad0ca52 (diff)
downloadnixlib-adaa110a72175c4f841722ab7d2bee7564656e91.tar
nixlib-adaa110a72175c4f841722ab7d2bee7564656e91.tar.gz
nixlib-adaa110a72175c4f841722ab7d2bee7564656e91.tar.bz2
nixlib-adaa110a72175c4f841722ab7d2bee7564656e91.tar.lz
nixlib-adaa110a72175c4f841722ab7d2bee7564656e91.tar.xz
nixlib-adaa110a72175c4f841722ab7d2bee7564656e91.tar.zst
nixlib-adaa110a72175c4f841722ab7d2bee7564656e91.zip
binutils: No more darwin conditionals
Since at least d7bddc27b23da8ce7bc19cfeeeb0cbebdb5a4410, we've had a
situation where one should depend on:

 - `stdenv.cc.bintools`: for executables at build time
 - `libbfd` or `libiberty`: for those libraries
 - `targetPackages.cc.bintools`: for exectuables at *run* time
 - `binutils`: only for specifically GNU Binutils's executables,
   regardless of the host platform, at run time.

and that commit cleaned up this usage to reflect that. This PR flips the
switch so that:

 - `binutils` is indeed unconditionally GNU Binutils
 - `binutils-raw`, which previously served that role, is gone.

so that the correct usage will be enforced going forward and everything
is simple.

N.B. In a few cases `binutils-unwrapped` (which before and now was
unconditionally actual GNU binutils), rather than `binutils` was used to
replace old `binutils-raw` as it is friendly towards some cross
compilation usage by avoiding a reference to the next bootstrapping
change.
Diffstat (limited to 'pkgs/development/compilers')
-rw-r--r--pkgs/development/compilers/emscripten-fastcomp/default.nix4
1 files changed, 2 insertions, 2 deletions
diff --git a/pkgs/development/compilers/emscripten-fastcomp/default.nix b/pkgs/development/compilers/emscripten-fastcomp/default.nix
index 490dace2faaf..10c1107da026 100644
--- a/pkgs/development/compilers/emscripten-fastcomp/default.nix
+++ b/pkgs/development/compilers/emscripten-fastcomp/default.nix
@@ -1,4 +1,4 @@
-{ newScope, stdenv, binutils-raw, wrapCCWith, symlinkJoin }:
+{ newScope, stdenv, binutils, wrapCCWith, symlinkJoin }:
 let
   callPackage = newScope (self // {inherit stdenv;});
 
@@ -7,7 +7,7 @@ let
     emscriptenfastcomp-wrapped = wrapCCWith {
       cc = self.emscriptenfastcomp-unwrapped;
       # Never want Apple's cctools for WASM target
-      bintools = binutils-raw;
+      bintools = binutils;
       libc = stdenv.cc.libc;
       extraBuildCommands = ''
         # hardening flags break WASM support