summary refs log tree commit diff
path: root/nixos
diff options
context:
space:
mode:
authorEelco Dolstra <eelco.dolstra@logicblox.com>2016-07-28 17:21:22 +0200
committerEelco Dolstra <eelco.dolstra@logicblox.com>2016-07-28 17:58:52 +0200
commitbf3edfbb3c75bc9cd640871fb4e0e9107dafaea1 (patch)
tree2ebf70367431d7fbae720d38316b965c5fd95dcf /nixos
parent42f8df10a2b984b1c76a05c0877ce4ef193457cd (diff)
downloadnixlib-bf3edfbb3c75bc9cd640871fb4e0e9107dafaea1.tar
nixlib-bf3edfbb3c75bc9cd640871fb4e0e9107dafaea1.tar.gz
nixlib-bf3edfbb3c75bc9cd640871fb4e0e9107dafaea1.tar.bz2
nixlib-bf3edfbb3c75bc9cd640871fb4e0e9107dafaea1.tar.lz
nixlib-bf3edfbb3c75bc9cd640871fb4e0e9107dafaea1.tar.xz
nixlib-bf3edfbb3c75bc9cd640871fb4e0e9107dafaea1.tar.zst
nixlib-bf3edfbb3c75bc9cd640871fb4e0e9107dafaea1.zip
nixos-containers: Use systemd 231's --notify-ready flag
Diffstat (limited to 'nixos')
-rw-r--r--nixos/modules/virtualisation/containers.nix14
1 files changed, 4 insertions, 10 deletions
diff --git a/nixos/modules/virtualisation/containers.nix b/nixos/modules/virtualisation/containers.nix
index b3870caece0c..036e54e3847f 100644
--- a/nixos/modules/virtualisation/containers.nix
+++ b/nixos/modules/virtualisation/containers.nix
@@ -32,10 +32,8 @@ let
         fi
       fi
 
-      # Start the regular stage 1 script, passing the bind-mounted
-      # notification socket from the host to allow the container
-      # systemd to signal readiness to the host systemd.
-      NOTIFY_SOCKET=/var/lib/private/host-notify exec "$1"
+      # Start the regular stage 1 script.
+      exec "$1"
     '';
 
   system = config.nixpkgs.system;
@@ -326,19 +324,17 @@ in
             fi
           ''}
 
-          rm -f $root/var/lib/private/host-notify
-
           # Run systemd-nspawn without startup notification (we'll
           # wait for the container systemd to signal readiness).
-          EXIT_ON_REBOOT=1 NOTIFY_SOCKET= \
+          EXIT_ON_REBOOT=1 \
           exec ${config.systemd.package}/bin/systemd-nspawn \
             --keep-unit \
             -M "$INSTANCE" -D "$root" $extraFlags \
             $EXTRA_NSPAWN_FLAGS \
+            --notify-ready=yes \
             --bind-ro=/nix/store \
             --bind-ro=/nix/var/nix/db \
             --bind-ro=/nix/var/nix/daemon-socket \
-            --bind=/run/systemd/notify:/var/lib/private/host-notify \
             --bind="/nix/var/nix/profiles/per-container/$INSTANCE:/nix/var/nix/profiles" \
             --bind="/nix/var/nix/gcroots/per-container/$INSTANCE:/nix/var/nix/gcroots" \
             --setenv PRIVATE_NETWORK="$PRIVATE_NETWORK" \
@@ -404,8 +400,6 @@ in
 
         Type = "notify";
 
-        NotifyAccess = "all";
-
         # Note that on reboot, systemd-nspawn returns 133, so this
         # unit will be restarted. On poweroff, it returns 0, so the
         # unit won't be restarted.