summary refs log tree commit diff
path: root/nixos
diff options
context:
space:
mode:
authorPeter Simons <simons@cryp.to>2014-11-02 12:34:16 +0100
committerPeter Simons <simons@cryp.to>2014-11-02 12:34:16 +0100
commit96a7e65c370733e74132836479711948c6824697 (patch)
treebbabb90be5b45bfe868d3c0d8e163ee93d096261 /nixos
parent831f3b25c01333fd5ff2ecc4fd236f5097636796 (diff)
downloadnixlib-96a7e65c370733e74132836479711948c6824697.tar
nixlib-96a7e65c370733e74132836479711948c6824697.tar.gz
nixlib-96a7e65c370733e74132836479711948c6824697.tar.bz2
nixlib-96a7e65c370733e74132836479711948c6824697.tar.lz
nixlib-96a7e65c370733e74132836479711948c6824697.tar.xz
nixlib-96a7e65c370733e74132836479711948c6824697.tar.zst
nixlib-96a7e65c370733e74132836479711948c6824697.zip
nixos/modules/services/monitoring/graphite.nix: don't create graphite user unconditionally
I'm not sure what exactly this user is needed for, i.e. under what circumstances
it must exist or not, but creating it unconditionally seems like the wrong thing
to do. I complained to @offlinehacker about this on Github, but got no response
for a week or so. I'm disabling the extraUsers bit to put out the fire, and now
hope that someone who actually knows about Graphite implements a proper solution
later.
Diffstat (limited to 'nixos')
-rw-r--r--nixos/modules/services/monitoring/graphite.nix20
1 files changed, 11 insertions, 9 deletions
diff --git a/nixos/modules/services/monitoring/graphite.nix b/nixos/modules/services/monitoring/graphite.nix
index e21ef167a4ec..ca3ecb00da4f 100644
--- a/nixos/modules/services/monitoring/graphite.nix
+++ b/nixos/modules/services/monitoring/graphite.nix
@@ -535,14 +535,16 @@ in {
       environment.systemPackages = [ pkgs.pythonPackages.graphite_pager ];
     })
 
-    {
-      users.extraUsers = singleton {
-        name = "graphite";
-        uid = config.ids.uids.graphite;
-        description = "Graphite daemon user";
-        home = dataDir;
-      };
-      users.extraGroups.graphite.gid = config.ids.gids.graphite;
-    }
+    # Disabled: Don't create this user unconditionally!
+    #
+    # {
+    #   users.extraUsers = singleton {
+    #     name = "graphite";
+    #     uid = config.ids.uids.graphite;
+    #     description = "Graphite daemon user";
+    #     home = dataDir;
+    #   };
+    #   users.extraGroups.graphite.gid = config.ids.gids.graphite;
+    # }
   ];
 }